Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: INT attribute format for WebGL2 #10347

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Feat: INT attribute format for WebGL2 #10347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9081eb9
Add provoke extension, which optimizes performance of "flat" fragment…
ivanpopelyshev Mar 20, 2024
b87cd18
INT attributes for WebGL2
ivanpopelyshev Mar 20, 2024
59f23f5
Forget import
ivanpopelyshev Mar 20, 2024
660b8c2
Merge branch 'dev' into webgl-provoking-vertex
Zyie Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/rendering/renderers/gl/context/GlContextSystem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,13 @@ export class GlContextSystem implements System<ContextSystemOptions>
...common,
colorBufferFloat: gl.getExtension('EXT_color_buffer_float'),
};

const provokeExt = gl.getExtension('WEBGL_provoking_vertex');

if (provokeExt)
{
provokeExt.provokingVertexWEBGL(provokeExt.FIRST_VERTEX_CONVENTION_WEBGL);
}
}
}

Expand Down
28 changes: 21 additions & 7 deletions src/rendering/renderers/gl/geometry/GlGeometrySystem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,8 +362,9 @@ export class GlGeometrySystem implements System
const attribute = attributes[j];
const buffer = attribute.buffer;
const glBuffer = bufferSystem.getGlBuffer(buffer);
const programAttrib = program._attributeData[j];

if (program._attributeData[j])
if (programAttrib)
{
if (lastBuffer !== glBuffer)
{
Expand All @@ -380,12 +381,25 @@ export class GlGeometrySystem implements System

const attributeInfo = getAttributeInfoFromFormat(attribute.format);

gl.vertexAttribPointer(location,
attributeInfo.size,
getGlTypeFromFormat(attribute.format),
attributeInfo.normalised,
attribute.stride,
attribute.offset);
const type = getGlTypeFromFormat(attribute.format);

if (programAttrib.format?.substring(1, 4) === 'int')
{
gl.vertexAttribIPointer(location,
attributeInfo.size,
type,
attribute.stride,
attribute.offset);
}
else
{
gl.vertexAttribPointer(location,
attributeInfo.size,
type,
attributeInfo.normalised,
attribute.stride,
attribute.offset);
}

if (attribute.instance)
{
Expand Down