Convert Accessibility to TypeScript #6379
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #6379 +/- ##
=======================================
Coverage 76.16% 76.16%
=======================================
Files 103 103
Lines 5840 5840
=======================================
Hits 4448 4448
Misses 1392 1392Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## dev #6379 +/- ##
=========================================
+ Coverage 76.01% 76.7% +0.69%
=========================================
Files 80 76 -4
Lines 4356 4142 -214
=========================================
- Hits 3311 3177 -134
+ Misses 1045 965 -80Continue to review full report at Codecov.
|
|
|
||
| interactionManager.dispatchEvent(e.target.displayObject, 'mouseout', interactionManager.eventData); | ||
| // TODO: Remove casting when CanvasRenderer is converted |
|
|
||
| export interface IDestroyOptions { | ||
| children?: boolean; | ||
| texture?: boolean; | ||
| baseTexture?: boolean; | ||
| } | ||
|
|
||
| export interface DisplayObject extends InteractiveTarget, EventEmitter {} | ||
| export interface DisplayObject extends InteractiveTarget, IAccessibleTarget, EventEmitter {} |
There was a problem hiding this comment.
Another cross-module reference to check when we convert all the modules.
|
@Zyie |
Yeah my bad I popped the wrong stash without realising |
|
Now you can change |
Done |
|
"Amputate left hand. |
Description of change
Converts accessibility to TypeScript.
Fairly simple conversion, just adding another mixin for DisplayObject and a new interface for an accessible HTMLElement.
I have removed the for loop that set its children's
divto null indestroy. I couldn't find any example ofdivbeing set so i believe this is not needed?Pre-Merge Checklist
npm run lint)npm run test)