Convert sprite-tiling to TypeScript #6398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 tasks
eXponenta
reviewed
Feb 11, 2020
Codecov Report
@@ Coverage Diff @@
## dev #6398 +/- ##
==========================================
+ Coverage 77.86% 77.97% +0.11%
==========================================
Files 68 67 -1
Lines 3885 3769 -116
==========================================
- Hits 3025 2939 -86
+ Misses 860 830 -30
Continue to review full report at Codecov.
|
bigtimebuddy
approved these changes
Feb 11, 2020
themoonrat
reviewed
Feb 12, 2020
| @@ -280,7 +283,7 @@ export class TilingSprite extends Sprite | |||
| * @param {number} height - the height of the tiling sprite | |||
| * @return {PIXI.TilingSprite} A new TilingSprite using a texture from the texture cache matching the frameId | |||
| */ | |||
| static fromFrame(frameId, width, height) | |||
| static fromFrame(frameId: string, width: number, height: number): TilingSprite | |||
There was a problem hiding this comment.
@bigtimebuddy - fromFrame and fromImage ... we deprecated these for Sprites and Textures in favour of just 'from' for v5, but looks like this got missed. Is there a case for doing that here too? Or wait until post TS conversion?
There was a problem hiding this comment.
I would rather do that as a follow up PR, but you’re right that was missed.
themoonrat
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Ok so slight complication with this one and not sure the best way round it.
The
TilingSprite.frommethod isnt compatible withSprite.fromasSprite.fromtakes a texture and some options whereasTilingSprite.fromtakes a texture, width, height.The solution i have committed here is:
static from(source: TextureSource, options: ISize): TilingSpriteIf anyone has better ideas let me know!
Pre-Merge Checklist
npm run lint)npm run test)