Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate TilingSprite's fromImage and fromFrame #6410

Merged
merged 4 commits into from
Feb 13, 2020

Conversation

bigtimebuddy
Copy link
Member

Follow up to #6398

These method represent work done in v4 to have explicit from* methods. In v5 we have largely abandoned these in favor of a single static from method. That's true for TilingSprite, but it was missed.

馃毥Deprecated

  • Removes TilingSprite.fromImage (use TilingSprite.from)
  • Removes TilingSprite.fromFrame (use TilingSprite.from)

@codecov-io
Copy link

codecov-io commented Feb 13, 2020

Codecov Report

Merging #6410 into dev will increase coverage by 2.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #6410      +/-   ##
==========================================
+ Coverage   76.23%   78.33%   +2.09%     
==========================================
  Files          63       57       -6     
  Lines        3089     2820     -269     
==========================================
- Hits         2355     2209     -146     
+ Misses        734      611     -123

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 711af5e...d54b1fe. Read the comment docs.

@bigtimebuddy bigtimebuddy merged commit 1d09bfc into dev Feb 13, 2020
@bigtimebuddy bigtimebuddy deleted the dev-tiling-from-deprecations branch February 13, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants