Fix isFastRect returning true if the rectangle is rotated #8094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigtimebuddy
approved these changes
Jan 8, 2022
themoonrat
approved these changes
Jan 8, 2022
bigtimebuddy
added
the
✅ Ready To Merge
dev7355608
added a commit
to pixijs/graphics-smooth
that referenced
this pull request
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Demo of failure: https://www.pixiplayground.com/#/edit/h0Qpfm3WlcSSgJP6FAvdG
I kept the check simple, but we could also add the same check as in
ScissorSystem.isMatrixRotatedif that is preferred.Pre-Merge Checklist
npm run lint)npm run test)