Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not full override of destroy method. #102

Closed
gfcrba opened this issue Oct 17, 2023 · 0 comments · Fixed by #103
Closed

Not full override of destroy method. #102

gfcrba opened this issue Oct 17, 2023 · 0 comments · Fixed by #103
Labels
bug Something isn't working

Comments

@gfcrba
Copy link

gfcrba commented Oct 17, 2023 •
edited
Loading

Hi! While solving a memory issue in my project I've noticed that you ignore 'options' passed to destroy method. And because of this no destroy method on this.list children called.
Expected: you receive options as declared in ancestor and pass it to destroy methods of DisplayObjects you destroy.
https://github.com/pixijs/ui/blob/main/src/ScrollBox.ts#L678
@gfcrba gfcrba added the bug Something isn't working label Oct 17, 2023
CyberDex added a commit that referenced this issue Oct 20, 2023
@CyberDex
Fix: Not full override of destroy method. #102
0239dbe
@CyberDex CyberDex mentioned this issue Oct 20, 2023
Merged
@CyberDex CyberDex linked a pull request Oct 20, 2023 that will close this issue
102 Not full override of destroy method. #103
Merged
CyberDex added a commit that referenced this issue Oct 20, 2023
@CyberDex
Fix: Not full override of destroy method. #102 (#103)
07a6f03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

102 Not full override of destroy method. pixijs/ui
1 participant
@gfcrba