Fix: Fancy Button Content Fitting #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbazukun123
requested review from
Zyie,
GoodBoyDigital and
CyberDex
as code owners
Zyie
approved these changes
Apr 4, 2024
Zyie
force-pushed
the
fix/fancy-button-content-fitting
branch
from
b9d1810
to
c84a6e2
Compare
Zyie
changed the title
Zyie
added a commit
that referenced
this pull request
May 22, 2024
Co-authored-by: Baz Utsahajit <baz.utsahajit@play.co> Co-authored-by: Zyie <24736175+Zyie@users.noreply.github.com> Fix: Fancy Button Content Fitting (#149)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fitToViewcall to prevent the persistent of scale < 1 from the initial fitting.eg. if the button default view texture has a width of 150 and the content text has a width of 200, it will apply 0.75 scaling to the text view to fit it within the button (assuming that the padding is 0). Then if the button width is then set to 250, the text will still remain at 0.75 despite that it no longer needed to be scaled down to fit within the button.
ignoreRefittingis provided in case the persistent scaling behaviour from before is preferred.fitToViewfunction to allow the child to maintain its aspect ratio from before the fitting.