Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0] VRMCoreLoaderPlugin #793

Merged
merged 4 commits into from
Aug 25, 2021
Merged

[1.0] VRMCoreLoaderPlugin #793

merged 4 commits into from
Aug 25, 2021

Conversation

0b5vr
Copy link
Contributor

@0b5vr 0b5vr commented Aug 20, 2021 •
edited
Loading

  • Based on feedback I received, This PR introduces VRMCoreLoaderPlugin that handles dependencies between each components
    • Removed dependency resolution system from each component plugins / extension plugins
      • because it was way too nasty
  • This also adds VRMCore
    • three-vrm-core examples now uses the VRMCore
    • VRM now inherits VRMCore
  • trivial refactor
    • move the definition of VRMParameters to a separated file

@0b5vr 0b5vr added Refactor Cool code is cool VRM 1.0 labels Aug 20, 2021
@0b5vr 0b5vr added this to the VRM 1.0 milestone Aug 20, 2021
@0b5vr 0b5vr self-assigned this Aug 20, 2021
@0b5vr 0b5vr merged commit 615843a into 1.0 Aug 25, 2021
@0b5vr 0b5vr deleted the vrm-core-class branch August 25, 2021 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@0b5vr 0b5vr

Labels
Refactor Cool code is cool VRM 1.0
Projects
None yet
Milestone
VRM 1.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@0b5vr