Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add compatibility for getHemisphereLightIrradiance #958

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

0b5vr
Copy link
Contributor

@0b5vr 0b5vr commented Apr 12, 2022

Description

The current getHemisphereLightIrradiance in mtoon.frag does not work starting from Three r133.
This PR fixes this.

Redo of #954 in the 1.0 branch.

@you74674 makes the original commit.

Redo of #954 in `1.0`

@you74674 makes the original commit
@0b5vr 0b5vr added bug Something isn't working VRM 1.0 labels Apr 12, 2022
@0b5vr 0b5vr added this to the VRM 1.0 milestone Apr 12, 2022
@0b5vr 0b5vr self-assigned this Apr 12, 2022
@0b5vr 0b5vr merged commit f180670 into 1.0 Apr 12, 2022
@0b5vr 0b5vr deleted the 1.0-fix-hemisphere branch April 12, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working VRM 1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant