[1.0] Re-introduce springbone center #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collision should be calculated in world space
0b5vr
added
bug
An attempt to address the temporary github actions degradation See: actions/cache#811
nyamadan
reviewed
Jun 7, 2022
| @@ -197,8 +168,6 @@ export class VRMSpringBoneJoint { | |||
| */ | |||
| public setInitState(): void { | |||
| // remember initial position of itself | |||
| this._centerSpacePosition.setFromMatrixPosition(this.bone.matrixWorld); | |||
There was a problem hiding this comment.
centerがVRMに含まれるようになったので最初に記録しておくことが不要となった。
nyamadan
reviewed
Jun 7, 2022
| .normalize() | ||
| .multiplyScalar(this._centerSpaceBoneLength) | ||
| .add(this._centerSpacePosition); | ||
| _nextTail.sub(_worldSpacePosition).normalize().multiplyScalar(this._worldSpaceBoneLength).add(_worldSpacePosition); |
There was a problem hiding this comment.
worldSpaceに戻したのでworldSpacePositionを減算するようになった。
nyamadan
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
centerto the serialized SpringBone fields.centeris applied: