-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.0] Re-introduce SpringBone center #374
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0b5vr
added
documentation
Improvements or additions to documentation
schema
SpringBone
labels
May 30, 2022
Based on the discussion in vrm-c#370
I was considering including the center space implementation in the reference code but I judged it would make the code too complex
毎度改行コードがムズすぎる…… |
ousttrue
approved these changes
May 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
もともとコントローラー等で高速移動する場合の対策でした。
VRMの外にある empty ノードを、ゲーム等の進行にあわせてプログラム制御する想定。
部位ごとに揺れを減らすのに利用したいという方向性を受け入れ。
0b5vr
added a commit
to pixiv/three-vrm
that referenced
this pull request
May 31, 2022
0b5vr
added a commit
to pixiv/three-vrm
that referenced
this pull request
May 31, 2022
This was referenced Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close #370
Description
本PRは、VRM1.0向けにSpringBoneのcenterのシリアライズを再導入します。
centerは、当初アプリケーション側の需要に応じて導入される機能であり、これがモデルに対してシリアライズされている必要性は低いと考えられていました。
しかし、モデルの1ノードをcenterとすることによって、激しく揺れて欲しくないSpringBoneの揺れを抑える使い方がされていました。
これを踏まえ、VRM1.0仕様に対して、VRM0.0に存在したcenterのシリアライズを改めて導入します。
Points need review