-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vp8/vp9 support to ffmpeg_vid_codecs #2863
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanangizz
reviewed
Nov 1, 2021
nanangizz
approved these changes
Nov 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me, just a minor below.
Thanks.
… *payload, no need out pointer
Add a new change: FUNC_PACKETIZE define change "const pj_uint8_t **payload " to "pj_uint8_t *payload" , because packetized video data already memcpy in this function, no need out pointer. |
sauwming
approved these changes
Nov 5, 2021
trengginas
approved these changes
Nov 5, 2021
oanaianc
pushed a commit
to jitsi/pjproject
that referenced
this pull request
May 12, 2023
oanaianc
added a commit
to jitsi/pjproject
that referenced
this pull request
May 12, 2023
This reverts commit 90b368c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title
#2862
By default, the codecs will be enabled when ffmpeg is enabled and
PJMEDIA_HAS_VPX_CODEC
(VP8/9 codecs usinglibvpx
) is not enabled. To disable the codecs, setPJMEDIA_HAS_FFMPEG_CODEC_VP8
andPJMEDIA_HAS_FFMPEG_CODEC_VP9
to zero.