Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vp8/vp9 support to ffmpeg_vid_codecs #2863

Merged
merged 4 commits into from
Nov 8, 2021
Merged

Conversation

jimying
Copy link
Contributor

@jimying jimying commented Oct 26, 2021

As title
#2862

By default, the codecs will be enabled when ffmpeg is enabled and PJMEDIA_HAS_VPX_CODEC (VP8/9 codecs using libvpx) is not enabled. To disable the codecs, set PJMEDIA_HAS_FFMPEG_CODEC_VP8 and PJMEDIA_HAS_FFMPEG_CODEC_VP9 to zero.

Copy link
Member

@nanangizz nanangizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me, just a minor below.
Thanks.

pjmedia/include/pjmedia-codec/config.h Show resolved Hide resolved
@jimying
Copy link
Contributor Author

jimying commented Nov 2, 2021

Add a new change: FUNC_PACKETIZE define change "const pj_uint8_t **payload " to "pj_uint8_t *payload" , because packetized video data already memcpy in this function, no need out pointer.

@nanangizz nanangizz merged commit 263886b into pjsip:master Nov 8, 2021
oanaianc pushed a commit to jitsi/pjproject that referenced this pull request May 12, 2023
oanaianc added a commit to jitsi/pjproject that referenced this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants