This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
Destructure Wrap/Wrapf into component operations #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecheney
force-pushed
the
destructure
branch
2 times, most recently
from
8ae1d01
to
2bc834e
Compare
Closed
| @@ -193,6 +205,18 @@ func Wrapf(err error, format string, args ...interface{}) error { | |||
| } | |||
| } | |||
|
|
|||
| // WithMessage annotates err with a new message. | |||
| // If err is nil, WithStack returns nil. | |||
There was a problem hiding this comment.
@cep21 please send a PR to this PR
|
Added PR to this PR to address the comment issue. Anything else I can help with to advance this PR? I can fix merge conflicts with master if you let me know whether you prefer merging master in or rebasing the PR on master and fixing that way. If there are any TODO items that could be tackled I could take a look as well -- would really like to see this functionality soon! |
This reverts commit 1b876e0.
Adds testFormatCompleteCompare as additional testing func. The new function takes a string slice as "want", wherein stacktraces and non-stacktrace messages are discerned by strings.ContainsAny(want[i], "\n"). For example usage, see TestFormatWithStack & TestFormatWithMessage.
davecheney
force-pushed
the
destructure
branch
from
1aaa9a1
to
17b7af7
Compare
|
I know this may be a bit silly, but WithMessagef would be nice addition as well. When converted "too many stack traces" code from Wrap -> WithMessage, converting Wrapf means an internal fmt.Sprintf(). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a result of the discussions at GopherCon. The focus of the branch is to decompose Wrap (and Wrapf) into their component operations, namely adding a message,
errors.WithMessageand adding a stack trace,errors.WithStackwhich were previously merged into one operation with Wrap.This is accomplished by adding two top level functions,
errors.WithMessageanderrors.WithStackand rewriting Wrap and Wrap to work in terms of these operations although a small deviation is present to make sure the recorded stack trace is correct.The motivation for this change was need to treat each of the following operations as distinct:
TODO: