This repository was archived by the owner on Dec 1, 2021. It is now read-only.
Refactor withMessage/withStack #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Destructure New/Errorf into two components, a call to the stdlib errors.New or fmt.Errorf to generate a _fundamental_ error, and then a call to withStack to attach a stack trace to the message.
Introduces WithMessage as well as errors.fundamental, errors.withMessage and errors.withStack internal types. Adjust tests for the new wrapped format when combining fundamental and wrapped errors.
The refactoring to use withStack and withMessage types is useful enough to land indepdently of exposing these helpers publically.
|
/cc FYI @dsnet |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is extracted from #76
This PR is a result of the discussions at GopherCon. The focus of the branch is to decompose
Wrap(andWrapf) into their component operations, namely adding a message,errors.withMessageand adding a stack trace,errors.withStackwhich were previously merged into one operation with Wrap.This is accomplished by rewriting
WrapandWrapfto work in terms of these operations although a small deviation is present to make sure the recorded stack trace is correct.The motivation for this change was need to treat each of the following operations as distinct: