Merge pull request #371 from ycombinator/gh-360/unused

Enabling unused lint check

.jshintrc

@@ -23,7 +23,7 @@
                                 //   "single" : require single quotes
                                 //   "double" : require double quotes
     "undef"         : false,     // true: Require all non-global variables to be declared (prevents global leaks)
-    "unused"        : false,     // true: Require all defined variables be used
+    "unused"        : true,     // true: Require all defined variables be used
     "strict"        : false,     // true: Requires all functions run in ES5 Strict Mode
     "maxparams"     : false,    // {int} Max number of formal params allowed per function
     "maxdepth"      : false,    // {int} Max depth of nested blocks (within functions)

examples/compute/amazon.js

@@ -5,3 +5,13 @@ var client = pkgcloud.compute.createClient({
   accessKey: 'asdfkjas;dkj43498aj3n',
   accessKeyId: '98kja34lkj'
 });
+
+client.getServers(function (err, servers) {
+  if (err) {
+    console.error(err);
+  }
+
+  servers.forEach(function (server) {
+    console.log(server.toJSON());
+  });
+});

examples/compute/joyent.js

@@ -12,6 +12,16 @@ var client = pkgcloud.compute.createClient({
   key: fs.readFileSync(path.join(process.env.HOME, '.ssh/id_rsa'), 'ascii')
 });
 
+client.getServers(function (err, servers) {
+  if (err) {
+    console.error(err);
+  }
+
+  servers.forEach(function (server) {
+    console.log(server.toJSON());
+  });
+});
+
 //
 // Alternatively create a client with a username / password pair
 //
@@ -21,3 +31,13 @@ var otherClient = pkgcloud.compute.createClient({
   password: 'your-password'
 });
 
+otherClient.getServers(function (err, servers) {
+  if (err) {
+    console.error(err);
+  }
+
+  servers.forEach(function (server) {
+    console.log(server.toJSON());
+  });
+});
+

examples/storage/amazon.js

@@ -5,3 +5,13 @@ var client = pkgcloud.storage.createClient({
   accessKey: 'asdfkjas;dkj43498aj3n',
   accessKeyId: '98kja34lkj'
 });
+
+client.getContainers(function (err, containers) {
+  if (err) {
+    console.error(err);
+  }
+
+  containers.forEach(function (container) {
+    console.log(container.toJSON());
+  });
+});

examples/storage/azure.js

@@ -5,3 +5,13 @@ var azure = pkgcloud.storage.createClient({
   storageAccount: 'test-storage-account',     // Name of your storage account
   storageAccessKey: 'test-storage-access-key' // Access key for storage account
 });
+
+azure.getContainers(function (err, containers) {
+  if (err) {
+    console.error(err);
+  }
+
+  containers.forEach(function (container) {
+    console.log(container.toJSON());
+  });
+});

examples/storage/rackspace.js

@@ -88,6 +88,7 @@ rackspace.getContainer('container-name', function (err, container) {
       return;
     }
     console.log('Successfully set bucket as CDN bucket');
+    console.log(cont);
   });  
 });
 
@@ -106,5 +107,6 @@ rackspace.getContainer('sample-container', function (err, container) {
     }
 
     console.log('Container ' + container.name + ' was successfully destroyed.');
+    console.log(result);
   });
 });

lib/pkgcloud/amazon/client.js

@@ -7,7 +7,6 @@
 
 var util = require('util'),
     AWS = require('aws-sdk'),
-    request = require('request'),
     pkgcloud = require('../../../../pkgcloud'),
     base = require('../core/base');
 

lib/pkgcloud/amazon/compute/client/groups.js

@@ -4,7 +4,6 @@
  */
 
 var errs  = require('errs'),
-    util = require('util'),
     _     = require('underscore');
 
 //

lib/pkgcloud/amazon/compute/client/images.js

@@ -6,7 +6,6 @@
  */
 var pkgcloud = require('../../../../../lib/pkgcloud'),
     base     = require('../../../core/compute'),
-    errs     = require('errs'),
     compute  = pkgcloud.providers.amazon.compute;
 
 //

lib/pkgcloud/amazon/compute/client/index.js

@@ -6,9 +6,7 @@
  */
 
 var AWS    = require('aws-sdk'),
-    qs     = require('querystring'),
     util   = require('util'),
-    urlJoin = require('url-join'),
     amazon = require('../../client'),
     _      = require('underscore');
 

lib/pkgcloud/amazon/compute/client/keys.js

@@ -5,8 +5,7 @@
  *
  */
 
-var errs  = require('errs'),
-    util = require('util');
+var errs  = require('errs');
 
 //
 // ### function listKeys (options, callback)
@@ -96,4 +95,4 @@ exports.destroyKey = function (name, callback) {
       ? callback(err)
       : callback(null, true);
   });
-};
+};

lib/pkgcloud/amazon/compute/client/servers.js

@@ -5,7 +5,6 @@
  *
  */
 var async = require('async'),
-    request  = require('request'),
     base     = require('../../../core/compute'),
     pkgcloud = require('../../../../../lib/pkgcloud'),
     errs     = require('errs'),

lib/pkgcloud/amazon/storage/client/files.js

@@ -5,10 +5,7 @@
  *
  */
 
-var fs = require('fs'),
-    request = require('request'),
-    util = require('util'),
-    base = require('../../../core/storage'),
+var base = require('../../../core/storage'),
     pkgcloud = require('../../../../../lib/pkgcloud'),
     through = require('through2'),
     storage = pkgcloud.providers.amazon.storage,

lib/pkgcloud/amazon/storage/client/index.js

@@ -8,7 +8,6 @@
 var util = require('util'),
     AWS = require('aws-sdk'),
     s3Stream = require('s3-upload-stream'),
-    pkgcloud = require('../../../../pkgcloud'),
     amazon = require('../../client'),
     _ = require('underscore');
 

lib/pkgcloud/amazon/storage/file.js

@@ -16,8 +16,6 @@ var File = exports.File = function File(client, details) {
 util.inherits(File, base.File);
 
 File.prototype._setProperties = function (details) {
-  var self = this;
-
   this.name = details.name || details.Key;
   this.etag = details.ETag || details.etag || null;
   this.lastModified = details.LastModified || details.lastModified || null;
@@ -33,4 +31,4 @@ File.prototype._setProperties = function (details) {
 
 File.prototype.toJSON = function () {
   return _.pick(this, ['name', 'etag', 'size', 'storageClass', 'lastModified', 'container', 'location' ]);
-};
+};

lib/pkgcloud/azure/client.js

@@ -6,7 +6,6 @@
  */
 
 var util = require('util'),
-    request = require('request'),
     base = require('../core/base');
 
 var Client = exports.Client = function (options) {

lib/pkgcloud/azure/compute/client/images.js

@@ -6,7 +6,6 @@
  */
 var pkgcloud = require('../../../../../lib/pkgcloud'),
   base     = require('../../../core/compute'),
-  errs     = require('errs'),
   compute  = pkgcloud.providers.azure.compute,
   azureApi = require('../../utils/azureApi');
 

lib/pkgcloud/azure/compute/client/index.js

@@ -5,8 +5,7 @@
  *
  */
 
-var qs = require('querystring'),
-    util = require('util'),
+var util = require('util'),
     urlJoin = require('url-join'),
     https = require('https'),
     auth = require('../../../common/auth'),

lib/pkgcloud/azure/compute/client/keys.js

@@ -5,8 +5,7 @@
  *
  */
 
-var errs  = require('errs'),
-    util = require('util');
+var errs  = require('errs');
 
 //
 // ### function listKeys (options, callback)
@@ -24,7 +23,7 @@ exports.listKeys = function (options, callback) {
   var self = this;
   options = options || {};
 
-  return this._query('DescribeKeyPairs', options, function (err, body, res) {
+  return this._query('DescribeKeyPairs', options, function (err, body) {
     return err
       ? callback(err)
       : callback(null, self._toArray(body.keySet.item));
@@ -71,7 +70,7 @@ exports.addKey = function (options, callback) {
       KeyName: options.name,
       PublicKeyMaterial: new Buffer(options.key).toString('base64')
     },
-    function (err, body, res) {
+    function (err) {
       return err
         ? callback(err)
         : callback(null, true);
@@ -90,10 +89,10 @@ exports.destroyKey = function (name, callback) {
   return this._query(
     'DeleteKeyPair',
     { KeyName: name },
-    function (err, body, res) {
+    function (err) {
       return err
         ? callback(err)
         : callback(null, true);
     }
   );
-};
+};

lib/pkgcloud/azure/compute/client/servers.js

@@ -4,8 +4,7 @@
  * (C) Microsoft Open Technologies, Inc.
  *
  */
-var async = require('async'),
-  base     = require('../../../core/compute'),
+var base   = require('../../../core/compute'),
   pkgcloud = require('../../../../../lib/pkgcloud'),
   errs     = require('errs'),
   azureApi = require('../../utils/azureApi'),
@@ -42,8 +41,7 @@ exports.getLimits = function getLimits(callback) {
 // Lists all servers available to your account.
 //
 exports.getServers = function getServers(callback) {
-  var self = this,
-      servers = [];
+  var self = this;
 
   azureApi.getServers(this, function (err, results) {
     if (err) {
@@ -123,7 +121,7 @@ exports.createServer = function createServer(options, callback) {
 exports.destroyServer = function destroyServer(server, callback) {
   var serverId = server instanceof base.Server ? server.id : server;
 
-  azureApi.destroyServer(this, serverId, function (err, res) {
+  azureApi.destroyServer(this, serverId, function (err) {
     if (callback) {
       return !err
         ? callback && callback(null, { ok: serverId })
@@ -142,7 +140,7 @@ exports.destroyServer = function destroyServer(server, callback) {
 exports.stopServer = function stopServer(server, callback) {
   var serverId = server instanceof base.Server ? server.id : server;
 
-  azureApi.stopServer(this, serverId, function (err, res) {
+  azureApi.stopServer(this, serverId, function (err) {
     return !err
       ? callback(null, { ok: serverId })
       : callback(err);
@@ -174,7 +172,7 @@ exports.createHostedService = function createHostedService(serviceName, callback
 exports.rebootServer = function rebootServer(server, callback) {
   var serverId = server instanceof base.Server ? server.id : server;
 
-  azureApi.rebootServer(this, serverId, function (err, res) {
+  azureApi.rebootServer(this, serverId, function (err) {
     return !err
       ? callback(null, { ok: serverId })
       : callback(err);

lib/pkgcloud/azure/compute/server.js

@@ -101,7 +101,6 @@ Server.prototype._setProperties = function (details) {
 
   // TODO: Need to clean up once I understand what is private ip?
   if (roleInstance) {
-    var ip =  roleInstance.IpAddress;
     addresses.public.push(roleInstance.InstanceEndpoints.InstanceEndpoint.Vip);
     addresses.private.push(roleInstance.IpAddress);
   } else {

lib/pkgcloud/azure/database/client/databases.js

@@ -10,8 +10,7 @@ var errs = require('errs'),
   templates = require('../../utils/templates'),
   PATH = require('path'),
   xml2js = require('xml2js'),
-  _ = require('underscore'),
-  url = require('url');
+  _ = require('underscore');
 
 // Encode a uri according to Azure Table rules
 // ### @options {uri} The uri to encode
@@ -67,7 +66,7 @@ exports.create = function (options, callback) {
         path: 'Tables',
         body: body,
         headers: headers
-      }, function (err, body, res) {
+      }, function (err, body) {
         if (err) { return next(err); }
 
         var parser = new xml2js.Parser();
@@ -95,7 +94,7 @@ exports.list = function (callback) {
   this._xmlRequest({
     method: 'GET',
     path: 'Tables'
-  }, function (err, body, res) {
+  }, function (err, body) {
     if (err) { return callback(err); }
     if (body && body.entry) {
       if (Array.isArray(body.entry)) {

lib/pkgcloud/azure/storage/client/containers.js

@@ -5,9 +5,7 @@
  *
  */
 
-var async = require('async'),
-    request = require('request'),
-    base = require('../../../core/storage'),
+var base = require('../../../core/storage'),
     pkgcloud = require('../../../../../lib/pkgcloud'),
     storage = pkgcloud.providers.azure.storage;
 
@@ -46,16 +44,15 @@ exports.getContainers = function (callback) {
 //
 exports.getContainer = function (container, callback) {
   var containerName = container instanceof storage.Container ? container.name : container,
-      self = this,
-      options;
+      self = this;
 
   this._xmlRequest({
     method: 'GET',
     path: containerName,
     qs: {
       restype: 'container'
     }
-  }, function (err, body, res) {
+  }, function (err, body) {
     return err
       ? callback(err)
       : callback(null, new (storage.Container)(self, body));
@@ -85,7 +82,7 @@ exports.createContainer = function (options, callback) {
     qs: {
       restype: 'container'
     }
-  }, function (err, body, res) {
+  }, function (err) {
     return err
       ? callback(err)
       : callback(null, new (storage.Container)(self, options));
@@ -104,8 +101,7 @@ exports.createContainer = function (options, callback) {
 // of the same name during this cleanup period, your call returns an error immediately.
 //
 exports.destroyContainer = function (container, callback) {
-  var containerName = container instanceof base.Container ? container.name : container,
-      self = this;
+  var containerName = container instanceof base.Container ? container.name : container;
 
   this._xmlRequest({
     method: 'DELETE',