Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure.storage.getFiles: Support paging marker & limit #628

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

azure.storage.getFiles: Support paging marker & limit #628

wants to merge 8 commits into from

Conversation

osher
Copy link

@osher osher commented Aug 8, 2018

Fixes #629

@osher
Copy link
Author

osher commented Aug 8, 2018

uh. still 2 openstack tests are failing which are irrelevant to my changes.

Can anybody help with that?

@cronopio
Copy link
Contributor

cronopio commented Aug 8, 2018

A good think that help to prioritize the merge is that you include tests of the functionality you're adding. Anyway, I see that the broken tests are not related but is possible that how the test was made could cause some interference.

Looks like this is the failing test and was added on pull request #493

I'll try to find some time to review in deep that specific test.

@osher
Copy link
Author

osher commented Aug 9, 2018

Well. Thanks.

Thing is that same test fails #626 - which does not add any functionality - and basically means that Azure adapter is completely broken, so I guess tests run only with mocks...

How about adding some e2e test which actually accesses the store and upload/download a single file, and list a container with paging?
Yes - we would need an Azure account for that - but I suspect the volume of builds will allow us to stay in a lowcost/free tier.

@osher
Copy link
Author

osher commented Aug 19, 2018

Still waiting to pull the fix of that broken openstack test 😢

@coveralls
Copy link

coveralls commented Dec 3, 2018

Coverage Status

Coverage decreased (-0.01%) to 71.153% when pulling 8b48fa4 on osher:patch-2 into c50daf5 on pkgcloud:master.

@osher
Copy link
Author

osher commented Dec 3, 2018

aha! ready to merge :)

@osher
Copy link
Author

osher commented Dec 20, 2018

Help anybody? @cronopio maybe?
there's also #626

@osher
Copy link
Author

osher commented Feb 7, 2019

Any news here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure.storage.getFiles - ignores paging options.
3 participants