New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure.storage.getFiles: Support paging marker & limit #628
base: master
Are you sure you want to change the base?
Conversation
uh. still 2 openstack tests are failing which are irrelevant to my changes. Can anybody help with that? |
A good think that help to prioritize the merge is that you include tests of the functionality you're adding. Anyway, I see that the broken tests are not related but is possible that how the test was made could cause some interference. Looks like this is the failing test and was added on pull request #493 I'll try to find some time to review in deep that specific test. |
Well. Thanks. Thing is that same test fails #626 - which does not add any functionality - and basically means that Azure adapter is completely broken, so I guess tests run only with mocks... How about adding some e2e test which actually accesses the store and upload/download a single file, and list a container with paging? |
Still waiting to pull the fix of that broken openstack test 😢 |
aha! ready to merge :) |
Any news here? |
Fixes #629