Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build (jshint + unit test) #642

Merged
merged 2 commits into from Nov 22, 2018
Merged

Conversation

Clement134
Copy link
Contributor

@Clement134 Clement134 commented Nov 21, 2018

Fix jshint errors et failing unit test.

./node_modules/.bin/jshint --exclude-path .gitignore .
lib/pkgcloud/amazon/storage/client/containers.js: line 131, col 12, 'deleteFiles' was used before it was defined.
lib/pkgcloud/amazon/storage/client/containers.js: line 135, col 12, 'destroyFile' was used before it was defined.

lib/pkgcloud/google/storage/client/containers.js: line 112, col 12, 'deleteFiles' was used before it was defined.
lib/pkgcloud/google/storage/client/containers.js: line 116, col 12, 'destroyFile' was used before it was defined.

lib/pkgcloud/openstack/context/identity.js: line 195, col 12, 'getTenantId' was used before it was defined.

lib/pkgcloud/openstack/context/service.js: line 114, col 12, 'getUrl' was used before it was defined.
lib/pkgcloud/openstack/context/service.js: line 131, col 12, 'endpointMatchDesiredInterface' was used before it was defined.

lib/pkgcloud/openstack/database/client/users.js: line 146, col 12, 'makeRequest' was used before it was defined.

test/common/base/client-test.js: line 41, col 16, 'handleResponse' was used before it was defined.
test/common/base/client-test.js: line 84, col 16, 'handleResponse' was used before it was defined.

test/common/databases/flavor-test.js: line 126, col 12, 'setupGetFlavorsMock' was used before it was defined.

11 errors
1) pkgcloud/openstack/storage/ The openstack Storage client copy should copy within the same container:
     Uncaught Error: No Match For: POST /v2.0/tokens
      at IncomingMessage.<anonymous> (/home/travis/build/pkgcloud/pkgcloud/node_modules/hock/lib/hock.js:364:15)
      at emitNone (events.js:86:13)
      at IncomingMessage.emit (events.js:185:7)
      at endReadableNT (_stream_readable.js:978:12)
      at _combinedTickCallback (internal/process/next_tick.js:80:11)
      at process._tickCallback (internal/process/next_tick.js:104:9)
  2) pkgcloud/openstack/storage/ The openstack Storage client copy "after each" hook:
     Error: timeout of 4000ms exceeded
      at Timeout.<anonymous> (/home/travis/build/pkgcloud/pkgcloud/node_modules/mocha/lib/runnable.js:158:19)
      at ontimeout (timers.js:386:11)
      at tryOnTimeout (timers.js:250:5)
      at Timer.listOnTimeout (timers.js:214:5)

@Clement134 Clement134 changed the title fix lint issues Fix build (jshint + unit test) Nov 22, 2018
@Clement134
Copy link
Contributor Author

@mattgrande, @rosskukulinski could you merge this PR to fix travis build and release a new version in npm ?

Copy link

@mattgrande mattgrande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@mattgrande mattgrande merged commit c50daf5 into pkgcloud:master Nov 22, 2018
@Clement134 Clement134 deleted the fix/build branch November 23, 2018 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants