Use libonenandone from source #671
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the 3 vulnerability warnings upon installation that stemmed from liboneandone's incorrect usage of an old mocha version. (see #644)
The package went unmaintained for months, and has only recently merged the old PR which fixed this issue. There hasn't been any activity on their side to publish an updated version to npm. We could wait for a new version to be published, but don't know when that will be (if ever).
It's not ideal to pull the package from its source, but if a new version isn't published to npm, the only alternatives would be to use a forked package, or drop the provider.