Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on non-portable compressed doman and newman arguments #477

Closed
thesamesam opened this issue Oct 18, 2022 · 0 comments · Fixed by #485
Closed

Warn on non-portable compressed doman and newman arguments #477

thesamesam opened this issue Oct 18, 2022 · 0 comments · Fixed by #485
Assignees
Labels
bash requires bash-parsing support check

Comments

@thesamesam
Copy link
Member

thesamesam commented Oct 18, 2022

See https://bugs.gentoo.org/619916. PMS does not state that compressed doman and newman arguments must be accepted, hence relying on them in ebuilds is nonportable.

Portage warns on this (this example is at 68c2e4bfc966c7ef2154474a14c7bdc338fd53cb, app-misc/socnetv-2.2):

 * QA Notice: doman argument '/var/tmp/portage/app-misc/socnetv-2.2/work/socnetv-2.2/man/socnetv.1.gz' is compressed, this is not portable
>>> Completed installing app-misc/socnetv-2.2 into /var/tmp/portage/app-misc/socnetv-2.2/image

 * Final size of build directory: 138300 KiB (135.0 MiB)
 * Final size of installed tree:   31696 KiB ( 30.9 MiB)

 * QA Notice: One or more compressed files were found in docompress-ed
 * directories. Please fix the ebuild not to install compressed files
 * (manpages, documentation) when automatic compression is used:
 *
 *   /usr/share/man/man1/socnetv.1.gz

but pkgcheck should be able to detect it statically.

Example bad calls:

src_install() {
	[...]

	doman foo.1.gz # .gz should not be here!
	newman foo.1.gz <anything> # .gz should not be in source!
}
@arthurzam arthurzam added check bash requires bash-parsing support labels Oct 18, 2022
arthurzam added a commit to arthurzam/pkgcheck that referenced this issue Oct 28, 2022
New check for catching passing compressed manpages to doman and newman.

Resolves: pkgcore#477
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
@arthurzam arthurzam self-assigned this Oct 28, 2022
arthurzam added a commit to arthurzam/pkgcheck that referenced this issue Oct 28, 2022
New check for catching passing compressed manpages to doman and newman,
and passing compressed info to doinfo and newinfo.

Resolves: pkgcore#477
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
arthurzam added a commit to arthurzam/pkgcheck that referenced this issue Oct 29, 2022
New check for catching passing compressed manpages to doman and newman,
and passing compressed info to doinfo and newinfo.

Resolves: pkgcore#477
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
arthurzam added a commit to arthurzam/pkgcheck that referenced this issue Oct 31, 2022
New check for catching passing compressed manpages to doman and newman,
and passing compressed info to doinfo and newinfo.

Resolves: pkgcore#477
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
arthurzam added a commit that referenced this issue Oct 31, 2022
New check for catching passing compressed manpages to doman and newman,
and passing compressed info to doinfo.

Resolves: #477
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bash requires bash-parsing support check
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants