-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for redundant inherits via @PROVIDES
#504
Comments
Did a simple implementation for this, here are 253 results: Results
|
Hmm, at least xdg-utils/gnome2-utils and multibuild-related are fishy. The problem with multibuild is that it exposes both functions that are supposed to be exposed indirectly, and functions that are meant to be used directly only. |
OK, I can add Also, I think this result should be style level, as warning I think is too much for this case. |
Resolves: pkgcore#504 Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Resolves: pkgcore#504 Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Right now we're using
@PROVIDES
not to report missing inherits for stuff indirectly exposed via other eclasses. Perhaps it'd be valuable to also report redundant inherits when we're only using the stuff that's exposed by another eclass.For example,
distutils-r1
providespython-r1 python-single-r1
. In that case, ifdistutils-r1
is inherited, pkgcheck would report directpython-r1
andpython-single-r1
inherits.Might be a good idea to check the results first to see if people wouldn't prefer direct inherits in some cases.
The text was updated successfully, but these errors were encountered: