Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on live ebuild with older EAPI than release #578

Closed
thesamesam opened this issue May 14, 2023 · 0 comments · Fixed by #579
Closed

Warn on live ebuild with older EAPI than release #578

thesamesam opened this issue May 14, 2023 · 0 comments · Fixed by #579
Assignees
Labels

Comments

@thesamesam
Copy link
Member

thesamesam commented May 14, 2023

If we have:

  • x-1.ebuild with EAPI=8
  • x-9999.ebuild with EAPI=7

then this implies the live ebuild is unmaintained and should be removed (or fixed, obviously, but probably removed).

We can do this either by checking for PROPERTIES="live" or we can do this based on version comparisons (which would include non-live ebuilds too). I fear the latter is too vulnerable to false positives where software has multiple branches, so let's do the PROPERTIES inspection instead.

i.e. Take the max of non-PROPERTIES="live" ebuilds for a package and take the min of all PROPERTIES="live" ebuilds for a package. If max_non_live_eapi > min_live_eapi, warn.

@arthurzam arthurzam self-assigned this May 14, 2023
arthurzam added a commit to arthurzam/pkgcheck that referenced this issue May 14, 2023
Resolves: pkgcore#578
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
@arthurzam arthurzam linked a pull request May 14, 2023 that will close this issue
arthurzam added a commit to arthurzam/pkgcheck that referenced this issue May 14, 2023
Resolves: pkgcore#578
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
arthurzam added a commit to arthurzam/pkgcheck that referenced this issue May 14, 2023
Resolves: pkgcore#578
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants