Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cythonized version of sequences.c #37

Closed
wants to merge 1 commit into from

Conversation

houseofsuns
Copy link
Contributor

First try at cython. I tested various aproaches, but ended up with the one used in the c version. I've got the feeling, that there is not that much that can be done here. This was most of the time a tad slower than the c version, but sometimes even faster.

@codecov-io
Copy link

Codecov Report

Merging #37 into master will decrease coverage by -0.1%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master     #37     +/-   ##
========================================
- Coverage   71.89%   71.8%   -0.1%     
========================================
  Files          44      44             
  Lines        5135    5135             
  Branches     1080    1080             
========================================
- Hits         3692    3687      -5     
- Misses       1265    1270      +5     
  Partials      178     178
Impacted Files Coverage Δ
snakeoil/sequences.py 96.29% <ø> (-3.09%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55b3e09...1c8c07d. Read the comment docs.

@radhermit
Copy link
Contributor

Sorry, I merged this a while ago and forgot to close this.

@radhermit radhermit closed this Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants