Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve examples description and structure #37

Merged
merged 6 commits into from
Sep 17, 2018
Merged

Conversation

pkosiec
Copy link
Owner

@pkosiec pkosiec commented Sep 14, 2018

Resolves #25
Related also to the discussion in #19

@pkosiec pkosiec added 📖 documentation All activites around documentation area/examples Refers to Mongo Seeding examples wip Work in progress labels Sep 14, 2018
@pkosiec pkosiec self-assigned this Sep 14, 2018
@pkosiec pkosiec force-pushed the improve-examples branch 6 times, most recently from 0a06387 to 776c629 Compare September 15, 2018 07:50
@pkosiec pkosiec removed the wip Work in progress label Sep 15, 2018
Repository owner deleted a comment Sep 15, 2018
Repository owner deleted a comment Sep 15, 2018
@pkosiec pkosiec changed the title Rename samples directory to examples Improve examples structure and description Sep 15, 2018
@pkosiec pkosiec changed the title Improve examples structure and description Improve examples description and structure Sep 15, 2018
@mjgs
Copy link

mjgs commented Sep 15, 2018

I've reviewed the updates as per your request. I still find the text confusing. Here are my observations and recommendations:

Although you call the tutorial page a tutorial when you link to it, the title of the page ("Import data definition") doesn't reflect that it's a tutorial, and I would say after reading the page, it isn't really a tutorial (specific steps to take to accomplish a result), it's more a description of the functionality.

A lot of the info on the tutorial page is already on the main page anyway.

The samples page feels more like a tutorial to me.

Maybe you should rename the Samples page Tutorial, and merge in all the old tutorial page into the main page, then remove the old tutorial page. It's just a suggestion, that's what I would do. I hope this is helpful to you.
[Updated: for clarity I reworded "tutorial page" to read "old tutorial page" in the above paragraph]

Repository owner deleted a comment Sep 16, 2018
Repository owner deleted a comment Sep 16, 2018
@pkosiec
Copy link
Owner Author

pkosiec commented Sep 16, 2018

Thank you @mjgs for review! Are you sure that you've seen the latest content? There is no samples directory anymore - this pull request changes it. You can see the updated repository content here: https://github.com/pkosiec/mongo-seeding/tree/9a56e9730d2ce4d22d05eee1e17db221b2721340

Repository owner deleted a comment Sep 16, 2018
Repository owner deleted a comment Sep 16, 2018
Repository owner deleted a comment Sep 16, 2018
Repository owner deleted a comment Sep 16, 2018
Repository owner deleted a comment Sep 16, 2018
Repository owner deleted a comment Sep 16, 2018
Repository owner deleted a comment Sep 16, 2018
Repository owner deleted a comment Sep 16, 2018
Repository owner deleted a comment Sep 16, 2018
Repository owner deleted a comment Sep 16, 2018
Repository owner deleted a comment Sep 16, 2018
Repository owner deleted a comment Sep 16, 2018
Repository owner deleted a comment Sep 16, 2018
Repository owner deleted a comment Sep 16, 2018
Repository owner deleted a comment Sep 16, 2018
Repository owner deleted a comment Sep 16, 2018
Repository owner deleted a comment Sep 16, 2018
Repository owner deleted a comment Sep 16, 2018
Repository owner deleted a comment Sep 16, 2018
Repository owner deleted a comment Sep 16, 2018
Repository owner deleted a comment Sep 16, 2018
Repository owner deleted a comment Sep 16, 2018
Repository owner deleted a comment Sep 16, 2018
Repository owner deleted a comment Sep 16, 2018
@mjgs
Copy link

mjgs commented Sep 17, 2018

@pkosiec yes I've seen the changed folder name, in my opinion the project needs more than a simple folder name change to make it understandable and accessible for users.

@pkosiec
Copy link
Owner Author

pkosiec commented Sep 17, 2018

@mjgs No, it wasn't only directory rename, I've written detailed instruction for every example from a scratch, including the one for custom Docker image. There shouldn't be confusion anymore, how to run examples. That was your main concern and that's why I've rebuilt this section.

Your points about data import tutorial were valid, so I adjusted that file as well in this pill request. However, I don't want to move it to main readme, because it has too much details - on main "page" user should meet just the basics, get the overall idea.

@mjgs
Copy link

mjgs commented Sep 17, 2018

@pkosiec You know the docs are definitely getting better! I can see you've made a lot of changes. The "import data definition link" is broken on the main page. In case you are not aware, that page also says tutorial in the title, not sure if you wanted to remove the tutorial word or not.

Something else I noticed, the example import pages lists Docker under Prerequisites, which is only the case presumably for when using the docker import method, right? If a user that is only wanting to use the cli method gets to that page, then that could be a road block for them.

@pkosiec
Copy link
Owner Author

pkosiec commented Sep 17, 2018

The "import data definition link" is broken on the main page.

Good catch! Fixed.

In case you are not aware, that page also says tutorial in the title, not sure if you wanted to remove the tutorial word or not.

Right, I switched to "guide".

Something else I noticed, the example import pages lists Docker under Prerequisites, which is only the case presumably for when using the docker import method, right? If a user that is only wanting to use the cli method gets to that page, then that could be a road block for them.

You're right! I've marked all the tools optional, because as you noticed they are not required.

Mark, many thanks for your contribution! You helped me a lot with the docs. I will merge this, but if you have any other ideas, suggestions or issues, please do not hesitate to contact me or write an issue 🙂 Again, a huge thank you!

@pkosiec pkosiec merged commit fe70e78 into master Sep 17, 2018
@pkosiec pkosiec deleted the improve-examples branch September 17, 2018 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/examples Refers to Mongo Seeding examples 📖 documentation All activites around documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants