pkp/immersion#85 Replaced SectionDAO calls with repository method #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vitaliy-1
reviewed
Jun 27, 2023
| @@ -183,8 +183,7 @@ public function addIssueTemplateData($hookname, $args) | |||
| $immersionSectionColors = $issue->getData('immersionSectionColor'); | |||
| if (empty($immersionSectionColors)) return false; // Section background colors aren't set | |||
|
|
|||
| $sectionDao = DAORegistry::getDAO('SectionDAO'); /** @var SectionDAO $sectionDao */ | |||
| $sections = $sectionDao->getByIssueId($issue->getId()); /** @var Section[] $sections */ | |||
| $sections = Repo::section()->getByIssueId($issue->getId()); /** @var \Illuminate\Support\LazyCollection $sections */ | |||
There was a problem hiding this comment.
No need to fix this. Return type is already specified for these new methods, thus phpdoc isn't required here or we can specify the type of individual items (as you already done below), although the latter is supported differently in IDEs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #85