fix migration problem with multilingual review forms #1782 #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
and sorry about the second commit, you can of course ignore that |
|
With apologies for the delay -- yes, this is exactly the fix. Thanks for spotting it. Rather than merging this PR with the second commit, I'll cherry-pick in the first commit manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating from OJS2 to OJS3 causes multilingual review forms to break and show "Array" as values.
Mentioned here: pkp/pkp-lib#1782
Although the discussion there suggests that the original code should be working, I could not get it to work without this change.
This code worked both with a clean install of 2.4.8.1 and our production server with 45 journals.