pkp/pkp-lib#4571 use getDefaultFormLocale in PKPSiteSettingsForm #2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
one submission test failed, looked like a glitch but restarted the tests. |
|
no, still the same thing with that single submission test. @asmecher can you check that? The only change involved in the pr is related to the site settings. |
|
Don't worry about that test failure, @ajnyga -- the tests are not currently very reliable, but I'm working on it. The failures are not related to your change. I've merged this (and the pkp-lib PR) and will forward-port to |
|
Could not find the same problem in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkp/pkp-lib#4571