pkp/pkp-lib#2294: Update frontend search to use GET instead of POST #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ctgraham, I suspect the URL munging will break with path info disabled in |
|
But I used @asmecher 's own URL munging solution from pkp/pkp-lib#2300. Surely you trust him? |
|
I wouldn't be so sure, that guy has a terrible memory :) |
|
@NateWr, this probably needs porting to Bootstrap3. |
|
Thanks, filed: https://github.com/NateWr/bootstrap3/issues/129 @Vitaliy-1 can you take care of this for the theme team's themes? |
This was referenced Aug 5, 2019
|
OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves pkp/pkp-lib#2294 for the default theme, while considering the increasingly unlikely case of pkp/pkp-lib#2300. Other themes may need to be updated.