[OJS] Returning to search from a search result leads to an expired document

[ajnyga]

Hi,

In OJS3 when you do a search, the form uses POST. This leads to a situation where a user clicks an article title and then tries to return back (using the browser back button like they usually do) to the search results, but ends up in Document Expired page.

This could be easily fixed if the search would use GET instead of POST. Any reasons why it should not @asmecher?

[asmecher]

GET is fine with me -- IIRC we did this with OJS 2.x. Do you mind submitting a PR? Or I'd be happy to do it too :)

[asmecher]

Beware of #2300 in fixing this!

[ajnyga]

Ok, so #2300 prevents from switching to GET? Or?

[asmecher]

You can switch to GET, but you'll need to address the way the form action URL is generated. When disable_path_info is on, it'll attempt to use URL parameters, which get clobbered by the form parameters.

[asmecher]

@ajnyga, I've just fixed #2300 -- that change will need to be ported to the master branch in order to prevent that problem for recurring here when we move to GETs. Not the tidiest solution but plenty effective for the two cases we need it for.