Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*8085* Add SPF enhancements ##ulsdevteam/add-spf-enhancements## #337

Merged
merged 1 commit into from
Oct 30, 2014

Conversation

ctgraham
Copy link
Contributor

Backport http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=8085 to dev-2_4. Also includes a new config variable to force a default envelope sender in the case of a multi-host install where the from address is not necessarily hosted on the same server.

@asmecher
Copy link
Member

Thanks, Clinton, I've reviewed this and it looks good. Would you mind rebasing so that I can merge directly? The lib/pkp submodule hash is out of date.

@bozana
Copy link
Contributor

bozana commented Oct 29, 2014

Have I understood it correctly, that the 3. solution for SPF problem i.e. noreply e-mail address is the same as the default_envelope_sender? If so, I am wondering if there should be maybe another variable for this noreply e-mail address -- shouldn't the envelope sender be the address that receives the bounce messages or errors and noreply a really noreply address? -- It is good to get/see the bounce messages and errors but the noreply address could be used in several applications for the same purpose and one could assume that these e-mails are not considered/read?

@ctgraham
Copy link
Contributor Author

Yes, the intent of this force_default_envelope_sender setting is to make sure all messages originate from the default envelope sender for SPF purposes. We had a journal which was in crisis mode because of non-delivered emails, and this was the closest extension of Alec's changes in bug 8085, so it was a quick fix. It works well if you can create a noreply address and attach your nondeliverable processing to that address.

For example:
Host: myjournal.org
default_envelope_sender: noreply@myjournal.org (forwarded to ojs@my.edu in postfix)
Site Principal Contact: ojs@my.edu
Journal Contact: editor@yahoo.com

@bozana
Copy link
Contributor

bozana commented Oct 29, 2014

Thanks Clinton! I think it will work well -- I was worried how it would work if the noreply@myinstitution.org is also used by other hosting groups/applications (e.g. OJS, Blogs, Wikis, CMS, ...) that don't necessarily have to know each other issues. But I think one could always get separate e-mail addresses, e.g. ojs-noreply@myinstitution.org cms-noreply@myinstitution.org ... :-)

asmecher added a commit that referenced this pull request Oct 30, 2014
*8085* Add SPF (Sender Protection Framework) enhancements
@asmecher asmecher merged commit e38535a into pkp:ojs-dev-2_4 Oct 30, 2014
@ctgraham ctgraham deleted the add-spf-enhancements branch October 31, 2014 19:08
ppv1979 pushed a commit to ppv1979/ojs that referenced this pull request Nov 5, 2014
jnugent added a commit that referenced this pull request Nov 5, 2014
Update ru_RU locale according to changes in  #337
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants