Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

registrationComplete page allows for UX issues #2492

Closed
ctgraham opened this issue May 4, 2017 · 4 comments
Closed

registrationComplete page allows for UX issues #2492

ctgraham opened this issue May 4, 2017 · 4 comments
Assignees
@bozana @NateWr
Milestone
OJS 3.1

Comments

@ctgraham
Copy link
Collaborator

ctgraham commented May 4, 2017

The ./user/registrationComplete page introduced in #1528 is:
@ctgraham ctgraham added this to the OJS 3.1 milestone May 4, 2017
@NateWr NateWr self-assigned this Jun 16, 2017
NateWr added a commit to pkp/bootstrap3 that referenced this issue Jun 20, 2017
@NateWr
pkp/pkp-lib#2492 Use consolidated register handler op in OJS 3.1
210784a
NateWr added a commit to NateWr/ojs that referenced this issue Jun 20, 2017
@NateWr
pkp/pkp-lib#2492 Consolidate registration in single URL op
327f6e5
NateWr added a commit to NateWr/pkp-lib that referenced this issue Jun 20, 2017
@NateWr
pkp#2492 Consolidate registration in single URL op
907e401
NateWr added a commit to NateWr/pkp-lib that referenced this issue Jun 20, 2017
@NateWr
pkp#2492 Fix source redirection during login/registration
a98ea9c
NateWr added a commit to NateWr/pkp-lib that referenced this issue Jun 20, 2017
@NateWr
pkp#2492 Don't show new submission link when no journal context exists
f85fa06
NateWr added a commit to NateWr/omp that referenced this issue Jun 20, 2017
@NateWr
pkp/pkp-lib#2492 Consolidate registration in single handler op
42d27b8
@NateWr
Copy link
Contributor

NateWr commented Jun 20, 2017

I removed the registerComplete op and instead consolidated the registraiton flow under register. The registerUser op is still available as a backwards-compatibility shim for third-party themes which submit the form to it.

I also removed the "make a submission" link if no context exists.

Thanks for the report @ctgraham.

PRs:
#2597
pkp/ojs#1431
pkp/omp#420

Tests running.

NateWr added a commit to NateWr/ojs that referenced this issue Jun 20, 2017
@NateWr
pkp/pkp-lib#2492 Consolidate registration in single URL op
ff38d78
NateWr added a commit to NateWr/pkp-lib that referenced this issue Jun 20, 2017
@NateWr
pkp#2492 Consolidate registration in single URL op
26f897a
NateWr added a commit to NateWr/pkp-lib that referenced this issue Jun 20, 2017
@NateWr
pkp#2492 Fix source redirection during login/registration
0045c58
NateWr added a commit to NateWr/pkp-lib that referenced this issue Jun 20, 2017
@NateWr
pkp#2492 Don't show new submission link when no journal context exists
9c5a1e3
NateWr added a commit to NateWr/ojs that referenced this issue Jun 20, 2017
@NateWr
pkp/pkp-lib#2492 Consolidate registration in single URL op
b917cd7
NateWr added a commit to NateWr/omp that referenced this issue Jun 20, 2017
@NateWr
pkp/pkp-lib#2492 Consolidate registration in single handler op
c2ccbe3
@NateWr
Copy link
Contributor

NateWr commented Jun 20, 2017

Tests passed, but it had to be rebased for a merge conflict. @bozana would you mind code reviewing?

@bozana
Copy link
Collaborator

bozana commented Jun 21, 2017

@NateWr, this looks good. I think you would need to rebase and add the submodule anew, then you can merge... :-)

NateWr added a commit to NateWr/pkp-lib that referenced this issue Jun 21, 2017
@NateWr
pkp#2492 Consolidate registration in single URL op
db71f7c
NateWr added a commit to NateWr/pkp-lib that referenced this issue Jun 21, 2017
@NateWr
pkp#2492 Fix source redirection during login/registration
56bb9c5
NateWr added a commit to NateWr/pkp-lib that referenced this issue Jun 21, 2017
@NateWr
pkp#2492 Don't show new submission link when no journal context exists
a31da6e
NateWr added a commit to NateWr/ojs that referenced this issue Jun 21, 2017
@NateWr
pkp/pkp-lib#2492 Consolidate registration in single URL op
9c62ac8
NateWr added a commit that referenced this issue Jun 21, 2017
@NateWr
Merge pull request #2597 from NateWr/i2492_registration_complete
bd58598 
#2492 Fix registration flow issues
NateWr added a commit to pkp/ojs that referenced this issue Jun 21, 2017
@NateWr
Merge pull request #1431 from NateWr/i2492_registration_complete
eafbc2f 
pkp/pkp-lib#2492 Fix registration flow issues
NateWr added a commit to pkp/omp that referenced this issue Jun 21, 2017
@NateWr
Merge pull request #420 from NateWr/i2492_registration_complete
7986346 
pkp/pkp-lib#2492 Fix registration flow issues
@NateWr
Copy link
Contributor

NateWr commented Jun 21, 2017

Cheers! Merged.

@NateWr NateWr closed this as completed Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bozana bozana

@NateWr NateWr

Labels
None yet
Projects
None yet
Milestone
OJS 3.1
Development

No branches or pull requests
3 participants
@bozana @NateWr @ctgraham