Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OMP] Spotlights broken in default theme due to missing javascript #2551

Closed
NateWr opened this issue May 29, 2017 · 2 comments
Closed

[OMP] Spotlights broken in default theme due to missing javascript #2551

NateWr opened this issue May 29, 2017 · 2 comments
Assignees
@NateWr
Labels
Bug:3:Critical A bug that prevents a substantial minority of users from using the software.
Milestone
OJS/OMP 3.1.1

Comments

@NateWr
Copy link
Contributor

NateWr commented May 29, 2017

The spotlights had a bit of JavaScript to toggle between them that was added in this commit: pkp/omp@93a83a2#diff-b80f46f36ee855b1f0c1d1ef54ead7f8

It was then accidentally removed when syncing changes from OJS default theme in this commit:

pkp/omp@97e22a3#diff-b80f46f36ee855b1f0c1d1ef54ead7f8L91
@NateWr NateWr self-assigned this May 29, 2017
@NateWr NateWr added the Bug:3:Critical A bug that prevents a substantial minority of users from using the software. label May 29, 2017
@NateWr NateWr added this to the OMP 3.1.1 milestone May 29, 2017
NateWr added a commit to NateWr/omp that referenced this issue Nov 8, 2017
@NateWr
pkp/pkp-lib#2551 Restore JS for spotlight display in default theme
4516ab3
@NateWr
Copy link
Contributor Author

NateWr commented Nov 8, 2017

PR:
pkp/omp#464

@bozana can you code review?

bozana added a commit to pkp/omp that referenced this issue Nov 8, 2017
@bozana
Merge pull request #464 from NateWr/i2551_spotlights
188c098 
pkp/pkp-lib#2551 Restore JS for spotlight display in default theme
@bozana
Copy link
Collaborator

bozana commented Nov 8, 2017

👍 Merged. Can the issue be closed?

@NateWr NateWr closed this as completed Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NateWr NateWr

Labels
Bug:3:Critical A bug that prevents a substantial minority of users from using the software.
Projects
None yet
Milestone
OJS/OMP 3.1.1
Development

No branches or pull requests
2 participants
@bozana @NateWr