Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Smarty to v3 #3242

Closed
asmecher opened this issue Jan 5, 2018 · 19 comments
Closed

Upgrade Smarty to v3 #3242

asmecher opened this issue Jan 5, 2018 · 19 comments
Assignees
Labels
Community:2:Priority Any issue that has been identified through research or feedback as a major community priority. Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Milestone

Comments

@asmecher
Copy link
Member

asmecher commented Jan 5, 2018

No description provided.

@asmecher asmecher self-assigned this Jan 5, 2018
asmecher added a commit to asmecher/pkp-lib that referenced this issue Jan 5, 2018
asmecher pushed a commit to asmecher/pkp-lib that referenced this issue Jan 5, 2018
asmecher added a commit to asmecher/pkp-lib that referenced this issue Jan 5, 2018
asmecher added a commit to asmecher/pkp-lib that referenced this issue Jan 5, 2018
asmecher added a commit to asmecher/pkp-lib that referenced this issue Jan 5, 2018
asmecher added a commit to asmecher/pkp-lib that referenced this issue Jan 5, 2018
asmecher added a commit to asmecher/pkp-lib that referenced this issue Jan 5, 2018
@asmecher asmecher mentioned this issue Jan 5, 2018
asmecher added a commit to asmecher/ojs that referenced this issue Jan 5, 2018
asmecher added a commit to asmecher/pkp-lib that referenced this issue Jan 5, 2018
asmecher pushed a commit to asmecher/pkp-lib that referenced this issue Jan 5, 2018
asmecher added a commit to asmecher/pkp-lib that referenced this issue Jan 5, 2018
asmecher added a commit to asmecher/pkp-lib that referenced this issue Jan 5, 2018
asmecher added a commit to asmecher/pkp-lib that referenced this issue Jan 5, 2018
asmecher added a commit to asmecher/pkp-lib that referenced this issue Jan 5, 2018
asmecher pushed a commit to asmecher/pkp-lib that referenced this issue Jan 5, 2018
asmecher added a commit to asmecher/pkp-lib that referenced this issue Jan 5, 2018
asmecher added a commit to asmecher/pkp-lib that referenced this issue Jan 5, 2018
asmecher added a commit to asmecher/pkp-lib that referenced this issue Jan 5, 2018
asmecher added a commit to asmecher/lensGalley that referenced this issue Jan 5, 2018
asmecher added a commit to pkp/staticPages that referenced this issue Jan 5, 2018
asmecher added a commit to pkp/translator that referenced this issue Jan 5, 2018
asmecher added a commit to pkp/pdfJsViewer that referenced this issue Jan 5, 2018
asmecher added a commit to pkp/addThis that referenced this issue Jan 5, 2018
asmecher added a commit to pkp/quickSubmit that referenced this issue Jan 5, 2018
asmecher added a commit to asmecher/bootstrap3 that referenced this issue Jan 5, 2018
@asmecher
Copy link
Member Author

asmecher commented Jan 5, 2018

@NateWr, one of the changes required in preparation for the upgrade to Smarty3 is to stop using our own custom |assign modifier, e.g.:

{translate|assign:"myVariableName key="some.locale.key.here"}

Instead, this needs to be wrapped in the standard {capture} function, e.g.:

{capture assign="myVariableName"}{translate key="some.locale.key.here"}{/capture}

This syntax is a little clunkier, but it's standard, and because of some nasty Smarty internals, it's a necessary change IMO.

This will definitely affect some of your theme templates -- I've already prepared a PR for the Bootstrap theme.

I haven't decided yet when to merge the Smarty3 upgrade, but converting |assign calls to {capture} works with Smarty2 and would probably be a good thing to do ASAP.

asmecher added a commit to asmecher/ojs that referenced this issue Jan 5, 2018
asmecher added a commit to pkp/pdfJsViewer that referenced this issue Jun 7, 2018
asmecher added a commit to pkp/staticPages that referenced this issue Jun 7, 2018
asmecher added a commit to pkp/translator that referenced this issue Jun 7, 2018
asmecher added a commit to asmecher/omp that referenced this issue Jun 7, 2018
asmecher added a commit to asmecher/omp that referenced this issue Jun 7, 2018
asmecher added a commit to asmecher/omp that referenced this issue Jun 7, 2018
asmecher added a commit to asmecher/omp that referenced this issue Jun 7, 2018
asmecher added a commit to asmecher/omp that referenced this issue Jun 7, 2018
asmecher added a commit to asmecher/omp that referenced this issue Jun 7, 2018
asmecher added a commit to asmecher/omp that referenced this issue Jun 7, 2018
asmecher added a commit to asmecher/omp that referenced this issue Jun 7, 2018
asmecher added a commit to asmecher/omp that referenced this issue Jun 7, 2018
asmecher added a commit to asmecher/omp that referenced this issue Jun 7, 2018
asmecher added a commit to asmecher/omp that referenced this issue Jun 7, 2018
asmecher added a commit to asmecher/omp that referenced this issue Jun 7, 2018
asmecher added a commit to asmecher/omp that referenced this issue Jun 7, 2018
@asmecher
Copy link
Member Author

asmecher commented Jun 7, 2018

Merged & closed!

@asmecher
Copy link
Member Author

asmecher commented Jun 7, 2018

(Thanks for a very helpful couple of review rounds, @NateWr.)

asmecher added a commit to pkp/omp that referenced this issue Jun 7, 2018
NateWr added a commit to NateWr/criticalTimes that referenced this issue Jun 11, 2018
@asmecher asmecher modified the milestones: OJS/OMP 3.2, OJS/OMP 3.1.2 Dec 21, 2018
JackBlackLight pushed a commit to cul/ojs-plugin-doi that referenced this issue Sep 15, 2021
JackBlackLight pushed a commit to cul/ojs-plugin-doi that referenced this issue Sep 15, 2021
JackBlackLight pushed a commit to cul/ojs-plugin-doi that referenced this issue Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community:2:Priority Any issue that has been identified through research or feedback as a major community priority. Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Projects
None yet
Development

No branches or pull requests

2 participants