Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Citation style language plugin doesn't work in some locales #3394

Closed
asmecher opened this issue Feb 16, 2018 · 2 comments
Closed

Citation style language plugin doesn't work in some locales #3394

asmecher opened this issue Feb 16, 2018 · 2 comments
Assignees
@bozana
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.

Comments

@asmecher
Copy link
Member

See this forum thread.

The relevant log entries are:

PHP Fatal error: Uncaught exception ‘Exception’ with message ‘String could not be parsed as XML’ in /home/politi30/public_html/casopis/plugins/generic/citationStyleLanguage/lib/vendor/seboettg/citeproc-php/src/Seboettg/CiteProc/Locale/Locale.php:48
Stack trace:
#0 /home/politi30/public_html/casopis/plugins/generic/citationStyleLanguage/lib/vendor/seboettg/citeproc-php/src/Seboettg/CiteProc/Locale/Locale.php(48): SimpleXMLElement->__construct(’’)
#1 /home/politi30/public_html/casopis/plugins/generic/citationStyleLanguage/lib/vendor/seboettg/citeproc-php/src/Seboettg/CiteProc/CiteProc.php(200): Seboettg\CiteProc\Locale\Locale->__construct(‘sr-RS@latin’)
#2 /home/politi30/public_html/casopis/plugins/generic/citationStyleLanguage/lib/vendor/seboettg/citeproc-php/src/Seboettg/CiteProc/CiteProc.php(160): Seboettg\CiteProc\CiteProc->init(false)
#3 /home/politi30/public_html/casopis/plugins/generic/citationStyleLanguage/CitationStyleLanguagePlugin.inc.php(382): Seboettg\CiteProc\CiteProc->render(Array, ‘bibliography’)
#4 /home/politi in /home/politi30/public_html/casopis/plugins/generic/citationStyleLanguage/lib/vendor/seboettg/citeproc-php/src/Seboettg/CiteProc/Locale/Locale.php on line 48

It looks like sr-RS@latin is getting passed in, and presumably the @latin part is causing CiteProc indigestion. OJS locales are mapped to CiteProc locales in CitationStyleLanguagePlugin.inc.php.
@NateWr NateWr added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Mar 6, 2018
bozana added a commit to bozana/citationStyleLanguage that referenced this issue Mar 16, 2018
@bozana
pkp/pkp-lib#3394 consider only sr-RS CSL locale
6d2f1ff
@bozana bozana mentioned this issue Mar 16, 2018
Merged
@bozana
Copy link
Collaborator

bozana commented Mar 16, 2018

PR: pkp/citationStyleLanguage#29

@NateWr, could you take a look?

@NateWr
Copy link
Contributor

NateWr commented Mar 19, 2018

👍 Merge when you'd like!

bozana added a commit to pkp/citationStyleLanguage that referenced this issue Mar 19, 2018
@bozana
Merge pull request #29 from bozana/master
42f64d2 
pkp/pkp-lib#3394 consider only sr-RS CSL locale
@bozana bozana self-assigned this Mar 19, 2018
@bozana bozana closed this as completed Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bozana bozana

Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asmecher @bozana @NateWr