Add filter by last modified more than X days ago to submissions lists

[asmecher]

• Clean up data model (for @asmecher)
• Add fitering to UI (for @NateWr)

[asmecher]

PRs:

• pkp/pkp-lib#4168 Fix modification/status modification column usage #4169
• pkp/pkp-lib#4168 Fix modification/status modification column usage ojs#2144
• pkp/pkp-lib#4168 Fix modification/status modification column usage omp#600

These standardize the last_modified and date_status_modified columns so that last_modified gets bumped on every UPDATE submissions, and date_status_modified gets bumped whenever something important happens (= a logged event). I'd suggest relying on the latter.

[NateWr]

👍 should I pull your branches in and build on top of that? Or do you want to merge to master and I'll implement the filtering based off that?

[asmecher]

@NateWr, I've merged those branches into master, thanks!

[NateWr]

The work that's left on this is pretty small and it's a huge priority every time we do the UI/UX groups at sprints. It feels like we should really make progress on this. @asmecher would you mind if I add this to the 3.2 milestone?

cc @alex-wreschnig

[asmecher]

@asmecher would you mind if I add this to the 3.2 milestone?

OK by me!

[NateWr]

@forgive38 If you look above, Alec has already done the backend work we need for a filter that would return submissions that have not been modified in the last X days.

For 3.2, we'd like to add a simple filter that returns submissions inactive for the last 30 days.

If you could do that, it'd be great!

[forgive38]

@NateWr : I looked at lastModified and dateStatusModified but I found sometimes these dates are not updated.
For example, when a reviewer complete a review these dates are not updated (even if you - as an Editor - confirm review and thank reviewer)
while when reviewer accept to review, these dates are updated

also no event when review are in, only these events in history :

• An email has been sent: [] Able to Review
• reviewer has accepted the round 1 review for submission 17.

So I think, if we want to have an analytic view for a journal editor, we have to rely on dateStatusModified and so, this one has to be updated on each modification

what do you think about it?

[NateWr]

It's been a while since I was looking at this issue, but I think what you need to look at is the date of the latest entry in the editorial history of a submission. Every piece of activity on a submission should be recorded here, and if it isn't, it should be added.

[NateWr]

All merged. Thanks very much for your work on this @forgive38! Will we see you at the PKP sprint in Barcelona?

@amandastevens this may effect documentation. It adds a new filter to the submissions list to view submissions that have had no activity for 30 days or more.