[OJS 3.1] Declined submissions not appropriately highlighted as such #3386
Comments
|
Submission tab now:
Submission tab proposal:
Revision tab now:
Revision tab proposal:
Similar approach for the other tabs. Generally speaking, the buttons should be replaced by a submission status. Only on the active stage, when it makes sense to record a decision, the buttons should be visible. Advanced features, like publishing twice or accepting without review should be less accessible. |
|
Yes, thanks for putting this together @pkel -- I like what you're proposing here. We'll examine this further, get back to you with any questions, and report back on next steps. |
|
We should probably look at how @bozana did the Editorial Recommendation notifications and mimic that approach. |
NateWr
added
the
Enhancement:1:Minor
amandastevens
added
the
Hosting
|
I second the proposal here, with an additional twist:
At a minimum, a similar notification to the "Review" tab should show up. |
|
The pull-request pkp/ojs#2072 contains a proposal on how we think this issue could be dressed. Following our original idea (comment #3386 (comment), @pkel ) I've tried to hide the buttons whenever a decision has already been made and show the latest recorded decision (dictionary only defined for en_US). As this was my first pull-request I am not sure whether everything worked as expected :). Some screenshots of how the changes look on the admin front end:
|
|
Thanks, @retostauffer! I think the PR was created against the wrong branch (as commented on it); see if you can straighten that out, and I'll leave the review to @NateWr (though it may be a week or so before he can get to it). |
|
Hy @asmecher , thanks for your reply. My bad, pull request against ojs:master rather than ojs:ojs-stable-3_1_1. I've made a new pull request where only the local changes are visible. Most of the changes, and there will be some logic-issues, have been made in the pkp-lib, followed the guidelines, hope that's done correctly (I kind of think .. not: retostauffer@88059b0). Sorry for that, new world for me :). |
|
Thanks @retostauffer. Can you make a pull request for the |
|
Sorry for my messed up pull request a month ago. I found some time for a new attempt:
The changes affect the action buttons on the admin interface. The idea is to hide (but not completely disable) these buttons as soon as an action has been recorded. At the moment it is hard to see for an editor whether or not he has to trigger an action (or the action has been triggered already). This could cause confusing situation if the editor triggers two different actions for the very same submission. |
|
Great work @retostauffer! I made a few small changes to this and I think it's ready for some tests. What I've changed:
PRs: @retostauffer would you be willing to do a bit of testing on this to make sure I haven't missed anything? I changed some of the conditional logic, so it'd be good to have a second round of testing. Submission stage Review stage Review stage in old round Copyediting stage When a submission is declined (all stages) |
|
@amandastevens @kaitlinnewson This issue will effect docs. |
|
Hy @NateWr Awesome! Thanks a lot in advance, looks great so far! I am more than willing to do some testing. We start testing 3.1.2 next Monday and I'll try to set up a blank installation (I assume that your commit is in the current master branch?) such that we also test this feature and provide some feedback a.s.a.p. Thanks again and all best from Austria, |
|
Yes, this is pegged against |
|
Hy @NateWr Took longer than planned to go trough it. I was not able to migrate our full system and tested your pull request on a fresh installation. Overall it looks pretty cool! Thanks a lot! I/we have noticed some things (maybe there's a reason for it), I hope it's OK to just list them here (t.b.d.). Well, it's basically one issue (and one smaller comment). The "Send to Production" and "Schedule for Publication" action buttons:
My suggestion: it would be an idea to hide these two buttons as long as no editor decision has been recorded? Even if no review process is needed we should still record the "Accept and Skip Review" decision. If the "Send to Production" and "Schedule for Publication" buttons would only be shown after a valid decision one could avoid sending stuff into the final stages without a decision. Or is there a technical/user need for this?
One small comment: after recording a decision the page does not change. Would it easily be possible to refresh the page (and restore the active tab) such that the action buttons will be hidden and the message appears (e.g., "Submission declined: Change decision"). Kind of a visual confirmation for the editor that the decision has been recorded by the system. What do you think? Unfortunately have not had time to try to implement this on my own ... sorry for that. All best and many thanks, |
|
Hey @NateWr |
|
My apologies again for the delay. Thanks for running some tests to make sure it worked out ok! Unfortunately, the pull requests will need to be refreshed, and there are some big changes coming to the workflow screen due to the introduction of version management. I will try to work this in with those changes in time for 3.2, which will probably go out Q3/Q4 (no promises!).
In OJS 3 we've introduced a flexible workflow, so there are no hard boundaries regarding the use of every stage. For that reason, we allow editors to activate all stages at any given time. Yes, this does introduce some ambiguity, but with the rise of preprints, early access, open review and other models, we need to be able to support non-linear workflows. So, for now at least, these buttons are available even if a review decision has not been made.
The message on the top of each stage tab indicates the last action taken on that stage. So even if the submission has "moved on", the submission stage will always say accepted for review if that was the decision made in that stage.
In most cases, we reload the page after a decision is made. But I remember hearing that this didn't happen in some cases. However, I can't seem to find the issue filed for this. If you can document the editorial actions that are taken that don't refresh the page, we can file that and try to address it in a future issue. |
|
FYI, I've updated the original post to reflect changes we're introducing with the new versioning feature. The work put into this has lingered longer than I would like so we're planning to roll it in with these changes to make sure it ships with v3.2. |
#3386 Hide editorial actions after decision made
pkp/pkp-lib#3386 Hide editorial actions after decision made
pkp/pkp-lib#3386 Hide editorial actions after decision made
|
Merged to @amandastevens and @kaitlinnewson: reminder that this will effect docs. See #3386 (comment) for screenshots of how the view of editorial decisions changes after a decision has been made in a stage. |
|
Hy @NateWr Great to hear! Thank you so much. I've patched our (test) system and it works very well. Love to see it being part of v3.2! Thanks for your efforts, |
|
Hi @retostauffer @NateWr @pkel : Thank you for this great work ! Just one point : when we decline submission in submission stage, we don't see immediately that the status changes, we have to refresh page. Maybe it's possible to update submissionEditorDecisionsDiv when decision is raised ? Thank you in advance |
|
Hy @forgive38 Ai, that's something I had on my todo list. Check @NateWr's comment #3386 (comment)
Not sure if we should wait for OJS 3.1.2-2 and see whether this issue has been addressed or not. Thanks a lot, |
|
If you can determine which actions are missing a page reload, then please file that as a new issue. I don't think that will have been addressed as part of this work. If you want to work on it yourself, look for the method |
* pkp/pkp-lib#5021 Restore subscription grid search options * Complete es_ES locale for CrossRef plugin Added missing translations for es_ES locale. * pkp/pkp-lib#5023 Fix obsolete constant name * Address Github security warnings * pkp/pkp-lib#5015 Changed lang attribute for local keys * pkp/pkp-lib#5015 Removed extra quotation mark * Update copyright date * fix typo in ru_RU locale * Submodule update * pkp/pkp-lib#5029 Bump PHP baseline to PHP7.2 * Bump citationStyleLanguage baseline to PHP7.2 * pkp/pkp-lib#5029 Submodule update ##asmecher/i5029-fix## * pkp/pkp-lib#5029 Disable PHP7.1 Travis tests * Complete API es_ES locales Added all missing texts for es_ES in api.xml * Submodule update * Minor fixes (proposals) Updated to september 4, 2019 * sl_SI-3_1_2_update * Correct XML path for validation * pkp/pkp-lib#2072 Working prototype of versioning based on new publication entity This commit includes all of the initial work done to support versioning based on a split between submissions and publications. All submission data related to publication, such as title, abstract, citations, authors and galleys, has been moved to a new publication entity. Submissions have a "one to many" relationship to Publications. Each Submission may have one or more Publications attached to it. Each Publication is treated as a new version. Published version data can not be modified. - New publication entity split from submissions - New API endpoints for publications - Workflow UI changes to support versions (publications) - Pre-publication validation checks - New STATUS_SCHEDULED for publications scheduled for publication in a future issue - Deprecated many methods on the Submission object - Upgrade scripts written from 3.1.x. - Tests updated to work, except for issue import. Some code is commented out or has not been updated yet. Progress on remaining support for versioning will be tracked in Github. See: https://github.com/pkp/pkp-lib/projects/15 * pkp/pkp-lib#2072 Fix whitespace and typo errors * pkp/pkp-lib#2072 Fix conflict with citation style language in template variable name * pkp/pkp-lib#2072 Fix tests * pkp/pkp-lib#2072 Drop temporary table during upgrade * Submodule update ##NateWr/i2072_versioning## * pkp/pkp-lib#2072 Fix fatal error when previewing article not assigned to issue * Submodule update * pkp/pkp-lib#5057 Update MEDRA dev endpoint URL * pkp/pkp-lib#5055 Fix author dashboard * Submodule update * Submodule update * pkp/pkp-lib#5068 Cast sequences to integers * Submodule update * Submodule update * Submodule update * Update ru_RU locale after pkp#2457 * allow gateway plugins to add authorization policies * Permit correct storage of section ID on initial insert * Submodule update * pkp/pkp-lib#5017 Include submission subtitle in Crossref XML * Submodule update * pkp/pkp-lib#4325 include affiliations for all authors * Remove unused variable * Recompile JS * pkp/pkp-lib#4989 Add defaultReviewMode setting on upgrade * Remove dead code * Submodule update * pkp/pkp-lib#5047 Don't allow galleys to be added or edited in published publications * Submodule update ##NateWr/i5047_galley_edit## * pkp/pkp-lib#5045 Restore keywords variables to article details template * Update pt_BR REVISED_VERSION_NOTIFY email template * pkp/pkp-lib#5089 fix variable test for section editor count * pkp/pkp-lib#4870 Support versioning on article landing page * Submodule update ##NateWr/i4870_reader_versioning## * pkp/pkp-lib#5087 Don't show category selection if no categories exist * pkp/pkp-lib#3386 Add new EditorialActionsHandler to minified scripts * Submodule update ##NateWr/i3386_editorial_actions## * Code syntax tweak * pkp/pkp-lib#4906 Remove OAI dependency on published_submissions * Revert 979337f * pkp/pkp-lib#5103 Remove sexist language * pkp/immersion#25 Move language-specific text into locale files * pkp/immersion#25 Fix test language (on disabled test) * pkp/immersion#25 Fix test language * Correct typo * pkp/pkp-lib#5044 Add date published field to journal entry form - Change date_published column from datetime to date - Remove unused publicationType and publicationDateType properties * Submodule update ##NateWr/i5044_date_published## * pkp/pkp-lib#5046 Add unpublish button to versions * pkp/pkp-lib#4779 Move to using XLIFF files for translation (work in progress) * pkp/pkp-lib#4779 Remove translator plugin * pkp/pkp-lib#4779 Adapt to PO files instead of XLIFF * pkp/pkp-lib#4779 Convert selected locales to PO * pkp/pkp-lib#4779 Submodule update ##asmecher/po## * pkp/pkp-lib#4779 Convert selected plugin locale files to PO * pkp/pkp-lib#4779 Submodule update * pkp/pkp-lib#4779 Convert pt_BR to PO format * Submodule update * Submodule update * pkp/pkp-lib#5045 Indicate publishing schedule in publish confirmation message * pkp/pkp-lib#5045 Use correct phrase for pre-publication tests * Submodule update ##NateWr/i5045_publish_message## * pkp/pkp-lib#5043 Add upgrade script to fix bad submission status * pkp/pkp-lib#4857 Fix schedule for publication button and move locale string to shared library * Submodule update ##NateWr/i4857_open_tab## * pkp/pkp-lib#4873 Fix dependent file handling for versioning - Deletes dependent files when galley deleted - Checks if file is used by a previous version before deleting * Submodule update ##NateWr/i4873_files## * Update ru_RU locale after PR pkp#2478 * Update ru_RU locale after PR pkp#2481 * pkp/pkp-lib#4859 Fix searching with addition of versioning * Submodule update * pkp/pkp-lib#5098 Update workflow template with changes to data * pkp/pkp-lib#5098 Update workflow handler with changes from pkp-lib * pkp/pkp-lib#5098 Fix tests * Submodule update ##NateWr/i5098_performance## * pkp/pkp-lib#5044 Use locale string from shared library * Submodule update ##NateWr/i5044_scheduled## * pkp/pkp-lib#4861 Migrates cover images to support versioning - Combines coverImage and coverImageAltText settings into one - Migrates settings to publication_settings table - Updates article landing page to show correct publication cover image * Submodule update ##NateWr/i4861_covers## * pkp/pkp-lib#5138 Fix capitalization of class name * pkp/pkp-lib#5139 Fix custom block manager plugin; remove extraneous code * Submodule update * Submodule update * pkp/pkp-lib#1375 Permit null issue Number and Year values * Clean up PHP warnings * Resolve count erroroneous call on DAOResultFactory * pkp/pkp-lib#5122 Support Iterator pattern for DAOResultFactories * pkp/pkp-lib#5122 Use Iterator pattern in search indexing * pkp/pkp-lib#4880 Properly skip XML import test (to avoid missing publication database inconsistency from broken import code) * pkp/pkp-lib#5122 Code review tweak * pkp/pkp-lib#5122 Scrutinizer tweaks * Submodule update * Submodule update * Submodule update * pkp/pkp-lib#5122 Facilitate the use of Iterators in service classes * pkp/pkp-lib#4859 Add metadata indexing to publication service * pkp/immersion#25 Tweak for fr_FR abbreviation * pkp/pkp-lib#4867 Initial work adding DOIs to publications * pkp/pkp-lib#4867 Add DOI preview to publish form * pkp/pkp-lib#4905 Restore support for exporting pub ids and metadata * Submodule update ##NateWr/i4867_dois## * Forward-port ae7c745 to master branch * Submodule update * pkp/pkp-lib#4804 Fix self-join problem on CrossRef upgrade SQL * pkp/pkp-lib#4924 Properly display access status for pay-per-view purchases * Fix filename typo * pkp/pkp-lib#4593 Fix incorrect access indications in category listing * Submodule update * Update ru_RU locale after PR pkp#2496 * Submodule update * Forward-port fr_CA emailTemplates.xml to master * pkp/pkp-lib#4168 Migrate submission date_status_modified to last_activity * pkp/pkp-lib#4168 Document new daysInactive API param * Submodule update ##NateWr/i4168_last_activity## * include two new email templates * two new email templates * two new email templates * two new email templates * two new email templates * two new email templates * two new email templates * two new email templates * pkp/pkp-lib#4867 Migrate DOI settings on upgrade * Add issue querybuilder filter for issue ids to support browsebysection plugin * Fix filter by section parameters in querybuilder * Fix conditional check on empty array in issue query builder * Submodule update * pkp/pkp-lib#5122 Fix check for empty DAOResultIterator and change naming pattern * pkp/pkp-lib#5122 Use Countable interface in DAOResultIterator * Submodule update * Fix PHP warnings/errors * pkp/pkp-lib#5216 Update links to in-app help * Add missing ID fetch * updated fr_CA translation * pkp/pkp-lib#5122 Update naming pattern when returning an iterator * Submodule update ##NateWr/i5122_iterator## * Submodule update: in-app help * pkp/pkp-lib#5526 Add missing templates in other languages during upgrade * pkp/pkp-lib#4705 Put code back to fix cover image issue * pkp/pkp-lib#5208 Update URN plugin to support publications - Adds FieldUrn component - Makes the check number generation available in more places - Updates plugin setting names * pkp/pkp-lib#5208 Remove extra whitespace * Submodule update ##NateWr/i5208_urn## * pkp/pkp-lib#4705 Fixed spacing * pkp/pkp-lib#4705 Removed spaces * pkp/pkp-lib#5011 Forward-port to master * Update ru_RU locale after PR pkp#2519 * Fix subject search * pkp/pkp-lib#4684 Added mobile nav menu for smaller screens * Replaced pkp_site_name in body.less to remove default 100% width * pkp/pkp-lib#4684 HTML adjustments for default theme mobile nav menu * pkp/pkp-lib#4684 Added close symbol to open mobile nav menu * pkp/pkp-lib#4684 Renamed classes * pkp/pkp-lib#4684 Toggle nav menu dropdowns on small/large screens * pkp/pkp-lib#4684 Moved .pkp_nav_list class to a media query * Moved .pkp_nav_list out of helpers, so deleting it * pkp/pkp-lib#4684 Fixed mobile nav styles, added two search bars * pkp/pkp-lib#4684 CSS for two menu bars WIP * pkp/pkp-lib#4684 Fixed what is showing and what is not in search bars * pkp/pkp-lib#4684 Styling mobile search bar * pkp/pkp-lib#4684 Added separate search form for mobile * pkp/pkp-lib#4684 Work out layout/design issues with mobile nav in default theme * pkp/pkp-lib#4684 Remove unused search form template * pkp/pkp-lib#4684 Improve style of task count in nav menus * pkp/pkp-lib#4684 Fix inaccessible user nav item due to lost hover * pkp/pkp-lib#4684 Fix mobile nav menu widths from phone to tablet size * pkp/pkp-lib#4684 Remove mobile user nav styles on large screens * pkp/pkp-lib#4684 Restore animated search styles in default theme header * pkp/pkp-lib#4684 Fix search form class and mobile nav padding * Submodule update ##NateWr/i4684_nav_menu##
Hi @NateWr, how are you? I have a similar problem, when reload a submission, the page is not updated, so the user needs to reload the page to check the status of the submission. I saw that the file BR, |
|
@matheusotoni can you file a new issue and include details on how to reproduce the problem you're facing and what version of OJS/OMP/OPS you are running? |
|
@asmecher |
|
Hi @Dhspdungkaka500, you can get help on our support forum at https://forum.pkp.sfu.ca/c/questions/5. |
Hi @NateWr . Thanks you very much, but I can't see support about the problem in question. You can send link details. Thanks! |
|
Hi @NateWr<https://github.com/NateWr> . Thanks you very much, but I can't see support about the problem in question. You can send link details. Thanks!
…________________________________
Từ: Nate Wright <notifications@github.com>
Đã gửi: 02 Tháng Hai 2021 8:02 SA
Đến: pkp/pkp-lib <pkp-lib@noreply.github.com>
Cc: Dũng Phạm Xuân <pxdung@ued.udn.vn>; Mention <mention@noreply.github.com>
Chủ đề: Re: [pkp/pkp-lib] [OJS 3.1] Declined submissions not appropriately highlighted as such (#3386)
Hi @Dhspdungkaka500<https://github.com/Dhspdungkaka500>, you can get help on our support forum at https://forum.pkp.sfu.ca/c/questions/5.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#3386 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMKVOAU2EQQ7DNNVAQXV6BDS46WS3ANCNFSM4EQ3GMIA>.
|
Updated (2019-07-03)
A mostly ready-to-go version of this request is implemented in PRs here: #3386 (comment). However, it needs to be rebased after the versioning changes and tested to make sure it still works correctly.
Also, it would be good to include more prominent Published/Declined indications at the top of the new workflow UI that is being introduced with versioning.
Original Report
I got reports, that users don't recognize the declined status of submissions.
The status is reported, but it seems to be not clear enough. The Accept Submission and Decline Submission buttons are the two most prominent items on the page and distract users from seeing the actual information. Similar issues arise on the submission tab, where declined information is missing and both Send to Review and Decline Submission are highlighted.
I suggest to hide actions on inactive stages and adapt their coloring dependent on the outcome of the review process.
The text was updated successfully, but these errors were encountered: