Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

externalFeed plugin broken in PHP7 #5439

Closed
jnugent opened this issue Jan 25, 2020 · 2 comments
Closed

externalFeed plugin broken in PHP7 #5439

jnugent opened this issue Jan 25, 2020 · 2 comments
Labels
Hosting Bug reports and feature requests from Publishing Services's hosted clients.

Comments

@jnugent
Copy link
Member

jnugent commented Jan 25, 2020

The externalFeed plugin in OJS 2.4 is broken in PHP7, because of calls to =& new. PR incoming.
@jnugent jnugent added the Hosting Bug reports and feature requests from Publishing Services's hosted clients. label Jan 25, 2020
@jnugent
Copy link
Member Author

jnugent commented Jan 25, 2020

This is low priority, and I realize there might not be a next version of OJS 2.4. It's nice for us though, because it means we can standardize our PHP versions on the servers without having to maintain patches.

asmecher added a commit to pkp/ojs that referenced this issue Jan 25, 2020
@asmecher
Merge pull request #2589 from jnugent/php7-compat-simplepie
e7b6a32 
pkp/pkp-lib#5439 fix calls to new for PHP7 compatibility
@asmecher
Copy link
Member

Don't forget to drop the PR link into the issue! pkp/ojs#2589

fgnievinski pushed a commit to fgnievinski/ojs that referenced this issue Apr 28, 2020
@jnugent @fgnievinski
pkp/pkp-lib#5439 fix calls to new for PHP7 compatibility
37fe521
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hosting Bug reports and feature requests from Publishing Services's hosted clients.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asmecher @jnugent