Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logged out users directed to site homepage instead of journal homepage when logo is present #5813

Closed
NateWr opened this issue May 4, 2020 · 2 comments
Closed

Logged out users directed to site homepage instead of journal homepage when logo is present #5813

NateWr opened this issue May 4, 2020 · 2 comments
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Milestone
OJS/OMP/OPS 3.2.1

Comments

@NateWr
Copy link
Contributor

NateWr commented May 4, 2020

Describe the bug
When a logged out user visits the homepage of a journal, and that journal has a logo, clicking on the link will take them to the site homepage. It should take them to the journal homepage. This applies to multi-journal instances.

To Reproduce
Steps to reproduce the behavior:

  1. Set up more than one journal.
  2. Go to Settings > Website > Appearance > Setup and add a logo to one journal.
  3. Visit that journal's homepage and click the logo.
  4. See that you are now at the site homepage instead of the journal homepage.

What application are you using?
3.2

Additional information
Report on the forum.
@NateWr NateWr added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label May 4, 2020
@NateWr NateWr added this to the OJS/OMP/OPS 3.2.0-4 milestone May 4, 2020
NateWr added a commit to NateWr/pkp-lib that referenced this issue May 21, 2020
@NateWr
pkp#5813 Fix url to homepage when logged in as not an admin
fe85a69
@NateWr
Copy link
Contributor Author

NateWr commented May 21, 2020

On investigation, I found it happened for logged-in users, but only when logged in as an author. I suspect this has something to do with {$multipleContexts} being available or not available in the template.

PR:
#5901

Tests:
pkp/ojs#2763

NateWr added a commit that referenced this issue May 25, 2020
@NateWr
Merge pull request #5901 from NateWr/i5813_homepage_url
1821fe0 
#5813 Fix url to homepage when logged in as not an admin
@NateWr
Copy link
Contributor Author

NateWr commented May 25, 2020

Merged.

@NateWr NateWr closed this as completed May 25, 2020
This was referenced Jun 17, 2020
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
None yet
Milestone
OJS/OMP/OPS 3.2.1
Development

No branches or pull requests
1 participant
@NateWr