-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OMP could use a Series Index page #6086
Comments
I'd be open to this. @asmecher and @withanage do you have any thoughts about this? One thing I'd like to see is to have the
This would require stepping in at https://github.com/pkp/omp/blob/master/pages/catalog/CatalogHandler.inc.php#L131-L133 and passing off to the correct template. @gemusehandler are you able to work on a PR for this (with the caveat that I'd like to hear from Alec and Dulip first)? |
Hi @NateWr I think this is a very good addition and a very good requirement.
This is a very good path approach One thing, which would be needed , if we have the series list, is the series info page too.
Another idea is : If we could use the REST API for for fetching metadata, that would be very good, cause we can use the same mapping for the API and the front-end and for performance issues, we can optimize the pagination etc. in REST in the longer run. |
Shouldn't this be included in the main series page? Similar to how we include a category description at the top of a category listing or the issue description at the top of an issue table of contents. |
yes, that is also an option. In Heidelberg, they really needed a very customizable page as a separate landing page. Another thing, that was noted is e.g. if we a have large number of of books in a series what is the best solution. If we paginate, we have to have to have the header in each paginated page, which some may like, but some may not like. Considering both those, I went for the separate page in python frontend, which was also helpful when they were advertising the book series launching or wanted to refer from other sources. |
That landing page for a specific series, doesn't it already exists? |
Ah yeah, I'd like to solve that in the original template. Subsequent pages can show a reduced series title area. Maybe a separate issue to consider... |
^ As @gemusehandler points out, there's already a page for this! |
@NateWr @asmecher |
The template name doesn't have any impact on the URL. So at the point in the code that I linked above, you can load any template you want, like this: if (!$series) {
// ... set up the series index template ...
return $templateMgr->display('frontend/pages/catalogSeriesIndex.tpl');
} |
PR = Pull Request I believe.
Sorry guys but I am a newly here.
… On 27 Jul 2020, at 12:16, Nate Wright ***@***.***> wrote:
I'd be open to this. @asmecher <https://github.com/asmecher> and @withanage <https://github.com/withanage> do you have any thoughts about this?
One thing I'd like to see is to have the seriesIndex path just be series. That way we have a good URL structure:
/catalog/series = a list of all series
/catalog/series/abcd = a list of all books in the abcd series
This would require stepping in at https://github.com/pkp/omp/blob/master/pages/catalog/CatalogHandler.inc.php#L131-L133 <https://github.com/pkp/omp/blob/master/pages/catalog/CatalogHandler.inc.php#L131-L133> and passing off to the correct template.
@gemusehandler <https://github.com/gemusehandler> are you able to work on a PR for this (with the caveat that I'd like to hear from Alec and Dulip first)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#6086 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABDGQS62YXVEC7C2MEEFHL3R5VHX5ANCNFSM4OXX642Q>.
|
Sorry @gemusehandler! Yep, PR = Pull Request. To provide a pull request you'll need to fork the project, get it running on your own local server based on the github repoository, and then create a branch and issue a pull request with the changes. You should be able to find resources online describing how to create a "fork" and create pull requests. Our documentation describes how to get OJS running on a local server based off of the github repository. |
Thanks for providing some directions. I think I managed.
… On 3 Aug 2020, at 12:59, Nate Wright ***@***.***> wrote:
Sorry @gemusehandler <https://github.com/gemusehandler>! Yep, PR = Pull Request. To provide a pull request you'll need to fork the project, get it running on your own local server based on the github repoository, and then create a branch and issue a pull request with the changes.
You should be able to find resources online describing how to create a "fork" and create pull requests. Our documentation describes how to get OJS running on a local server <https://docs.pkp.sfu.ca/dev/documentation/en/getting-started> based off of the github repository.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#6086 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABDGQS2KMJ4F4PHDKVNCO5DR62J7NANCNFSM4OXX642Q>.
|
PR: pkp/omp#855 @gemusehandler, to keep pull requests and issues linked, we use a convention that includes the issue ID in the pull request title:
That'll cause the pull request to be linked to the related issue, and vice versa. @NateWr, I see you've already been watching over this; could you take a look? |
Thanks @gemusehandler! I've made some comments on the PR but it is looking good. 👍 One thing we still need to figure out is how will readers get to this page? Some ideas:
Any thoughts on this? cc @withanage |
@NateWr If the top navigation can have the series index page without opening individual dropdowns, that would be really great! |
Thanks @withanage! @gemusehandler did you have any questions about the comments here or on the pull request? We can talk through anything you need to continue work on it. |
I think I managed.
… On 24 Aug 2020, at 10:23, Nate Wright ***@***.***> wrote:
Thanks @withanage <https://github.com/withanage>! @gemusehandler <https://github.com/gemusehandler> did you have any questions about the comments here or on the pull request? We can talk through anything you need to continue work on it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#6086 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABDGQS3YCJUVL2W3V4NBQA3SCIPRBANCNFSM4OXX642Q>.
|
Hi @NateWr @gemusehandler |
When it comes to books (or monographs) then from an academic point of view, book series are essential. Books series provide a path to academic recognition. Books series can for instance be included in academic indexes such as Scopus, standalone books can't. Wouldn't it be a good idea when OMP allows presses to present series more prominently? We though it is! We developed a seriesindex page that provides an effect overview of the series that are included in a press. And we like to see this seriesindex page to become part of the regular OMP installation.
How did we do it? We added a catalogSeriesIndex.tpl to the installation. It requires a small additions to the index.php page and the CatelogHandler.inc.php. These modifications are highlighted in the files with: /** GEMUSEHANDLER begin modification:
Please see the files at my GIST page at Github
Here is a slightly older version of the page in action:
Correct: the example displays the Print/Online ISSN header when there is actually noting to display. This has been resolved in the coding on the GIST pages
The text was updated successfully, but these errors were encountered: