Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the discovery of submodules in the build script #7587

Closed
jonasraoni opened this issue Jan 4, 2022 · 2 comments
Closed

Improve the discovery of submodules in the build script #7587

jonasraoni opened this issue Jan 4, 2022 · 2 comments
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.

Comments

@jonasraoni
Copy link
Contributor

Describe the problem you would like to solve
At this moment we have to create a commit containing the text ##github-username/branch-name## to hint the build script where to look for updated submodules.

Describe the solution you'd like
Update the script startSubmodulesTRAVIS.sh to look for submodules/matching hashes automatically at the PR's origin.

Who is asking for this feature?
Developer
@jonasraoni jonasraoni added the Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day. label Jan 4, 2022
@henriqueramos
Copy link
Contributor

Already made on #7125.

https://github.com/pkp/ojs/pull/3160/files#diff-8f16e27c2e43ab2ebfaa7bf22fb77c3be7e92671fc0d73cc33ef8c47517d0df5

@jonasraoni
Copy link
Contributor Author

jonasraoni commented Feb 1, 2022 •
edited
Loading

I created this issue to go one step forward, and avoid the need of creating a commit with the message ##github-username/branch-name## =]

@pkp pkp locked and limited conversation to collaborators May 31, 2022
@jonasraoni jonasraoni converted this issue into discussion #7982 May 31, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Assignees
No one assigned
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Projects
Infrastructure
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonasraoni @henriqueramos