Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

piwik plugin doesn't play well with others #819

Closed
ctgraham opened this issue Oct 14, 2015 · 1 comment
Closed

piwik plugin doesn't play well with others #819

ctgraham opened this issue Oct 14, 2015 · 1 comment
Milestone
OJS 2.4.7-1

Comments

@ctgraham
Copy link
Collaborator

See: http://forum.pkp.sfu.ca/t/google-analytics-in-ojs-2-4-6-0/4617

Piwik plugin overwrites the output in insertFooter() rather than appending to it.
https://github.com/pkp/ojs/blob/fddc0a90d6ca922117f2384e12ab1d2046d7c4a1/plugins/generic/piwik/PiwikPlugin.inc.php#L172
ctgraham added a commit to ulsdevteam/ojs that referenced this issue Oct 14, 2015
@ctgraham
pkp/pkp-lib#819: change piwik plugin output to append rather than ove…
dbcf8d3 
…rwrite footer
@ctgraham ctgraham mentioned this issue Oct 14, 2015
Merged
asmecher added a commit to pkp/ojs that referenced this issue Oct 14, 2015
@asmecher
Merge pull request #641 from ulsdevteam/piwik-append-footer
284081d 
pkp/pkp-lib#819: change piwik plugin output to append rather than overwrite footer
asmecher pushed a commit to pkp/ojs that referenced this issue Oct 14, 2015
@ctgraham @asmecher
pkp/pkp-lib#819: change piwik plugin output to append rather than ove…
787a679 
…rwrite footer
@asmecher asmecher added this to the OJS 2.4.7-1 milestone Oct 14, 2015
@asmecher
Copy link
Member

Merged and cherry-picked to ojs-stable-2_4_7. Thanks again, @ctgraham!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
OJS 2.4.7-1
Development

No branches or pull requests
2 participants
@asmecher @ctgraham