Improve Editorial Activity calculations

[bozana]

s. https://forum.pkp.sfu.ca/t/editorial-activity-statistics-look-strange-ojs-3-4-0-4/87021/13

• Editorial Activity > Submissions In Progress checks after the old value '0' in the submission_progress column.
  In 3.4 the values for submission_progress column have changed, s. https://github.com/pkp/pkp-lib/blob/stable-3_4_0/classes/migration/upgrade/v3_4_0/I7191_SubmissionProgressType.php.
  However the code to get the number of submissions in progress for the editorial activity page still checks after the old value '0'. Consider here the new value '', but also the old value 0, because the QuickSubmit plugin still inserts old values.
• Consider the new value '' in the submission_progress column here https://github.com/pkp/pkp-lib/blob/stable-3_4_0/classes/services/queryBuilders/PKPStatsEditorialQueryBuilder.php#L390.
• Use $this->getAcceptedDecisions() here https://github.com/pkp/pkp-lib/blob/stable-3_4_0/classes/services/PKPStatsEditorialService.php#L65, in order to calculate the acceptance rate calculated correctly.

PRs:
stable-3_4_0:

• pkp/pkp-lib#9813 fix bugs in editorial activity stats #9848
• pkp/pkp-lib#9813 upgrade script to fix frong submission progress values inserted by QuickSubmit plugin ojs#4241
• pkp/pkp-lib#9813 submodule update ##bozana/stable-3_4_0## omp#1551 (only submodule update)
• pkp/pkp-lib#9813 submodule update ##bozana/stable-3_4_0## ops#664 (only submodule update)

main:

• pkp/pkp-lib#9813 fix bugs in editorial activity stats #9907
• pkp/pkp-lib#9813 upgrade script to fix wrong submission progress values inserted by QuickSubmit plugin ojs#4252

[bozana]

@jonasraoni, could you please review the PR above?
I am not 100% sure about using getAcceptedDecisions() instead of Decision::ACCEPT in the function PKPStatsEditorialService::getAverages(), but I think it is correct, because all the other numbers consider all the accept decisions from getAcceptedDecisions() and not only Decision::ACCEPT. Maybe you can also double think about it :-)
Thanks a lot!

[bozana]

Hi @jonasraoni, could you take a look at the PR above?

[jonasraoni]

Okay, I'll take a look.

p.s.: This part of the code, with exceptions for the QuickSubmit, that doesn't align very well with the other types of data import (NativeXML) is a great source of confusion 😁

[bozana]

Hi @jonasraoni, I changed it as said. Could you please take another look and the PRs above?
Thanks a lot!