Issue #1963: add Shibboleth authentication capability #2661

crism · 2017-07-19T20:51:08Z

Fixes #1963.
Tested with multiple users with existing accounts and new ones, from multiple entry and exit points.

asmecher · 2017-09-26T19:52:27Z

plugins/generic/shibboleth/pages/ShibbolethHandler.inc.php

+
+		// We rely on these headers being present.
+		if (!isset($_SERVER[$uinHeader])) {
+			syslog(


@crism, we've generally used error_log rather than syslog in the past -- is there a reason for introducing a different logging pattern here? I'd worry that admins won't be used to looking there for OJS-related stuff.

The previous Shibboleth plugin used syslog() and I tried to reuse as much of that code as possible. I’d rather use error_log().

asmecher · 2017-09-26T19:53:02Z

plugins/generic/shibboleth/pages/ShibbolethHandler.inc.php

+	 * 
+	 * @return ShibbolethAuthPlugin
+	 */
+	function &_getPlugin() {


References on objects aren't needed with PHP5+.

More cut-and-paste from the predecessor (or maybe some other plugin)—that can go.

asmecher · 2017-09-26T19:53:30Z

plugins/generic/shibboleth/pages/ShibbolethHandler.inc.php

+		$userId = $user->getId();
+		$adminFound = array_search($uin, $admins);
+
+		$userGroupDao =& DAORegistry::getDAO('UserGroupDAO');


Unnecessary reference use (probably also elsewhere) -- there are lots of these in the codebase, but we're trying to clean them up as we go.

More cut-and-paste.

asmecher · 2017-09-26T19:55:07Z

Looks good, @crism, and sorry I missed this earlier. Just a few questions/tweaks, but this could also use a fresh push to trigger Travis testing -- a lot of master branch stuff has changed since July.

vieville · 2017-10-04T10:19:59Z

@crism, I tried to load this pull with the command :
git fetch origin pull/#2661/head:shib
which returns : fatal: Couldn't find remote ref pull/#2661/head
It's certainly not the rigth command !

Please, can you send me the rigth command ?

Thank you

Claude

…tion...

crism · 2017-10-12T16:29:14Z

@asmecher, I think this addresses your comments. Sorry for the delay.

crism · 2017-10-12T16:30:20Z

@vieville, you can’t pull a pull request. Add my fork as a remote and check out the issue-1963 branch.

asmecher · 2017-10-20T03:29:25Z

Excellent, @crism, and just in time for OJS 3.1 -- many thanks!

asmecher · 2017-10-20T03:38:26Z

...except I moved it out of the pkp-lib repo into the ojs repo!

kasioumis · 2017-10-20T09:03:43Z

This is excellent news, @crism @asmecher thank you very much!

crism · 2017-10-20T14:50:02Z

@asmecher it should work with O*S… why move it?

asmecher · 2017-10-20T15:07:09Z

Ooh, neat! I spotted a reference to journal managers in ShibbolethSettingsForm and assumed -- but I'm more than happy to hear it's agnostic.

The best thing to do with this will be to move it to its own repository, then make it available via the plugin gallery. I'll do that and drop you a link.

asmecher · 2017-10-20T15:11:14Z

It lives! https://github.com/pkp/shibboleth

crism · 2017-10-20T15:15:53Z

@asmecher, yes, journal managers are mentioned in a comment; I tried to genericize everything, but missed that one. Thanks for setting up that repo!

asmecher · 2017-10-20T15:19:42Z

@crism, I've added you as an admin to that repo. The next things that'll need doing are tagging and building a .tar.gz release, and adding it to the plugin gallery -- I'll do that after the OJS 3.1 release comes out, and use it as an opportunity to document that process in a blog post.

kasioumis · 2017-11-05T00:13:58Z

Hi @asmecher and @crism, thanks again for this plugin :-) As far as I understand the plan is to host it in the generic plugins and not that auth ones, right? I'm looking forward to the official .tar.gz release and respective blog post about the plugin gallery. In the meantime, what is the best way to install shibboleth? Simply copy the folder structure into plugins/generic or manually package the folder structure into a single .tar.gz and then install that via the web form?

asmecher · 2017-11-07T01:05:21Z

@kasioumis, I've just added the plugin to the Plugin Gallery; please let me know whether that works for you.

kasioumis · 2017-11-07T11:08:07Z

@asmecher Thanks!

On vanilla OJS 3.1.0 I installed the shibboleth plugin via the Plugin Gallery. When trying to enabled it in the list of Installed Plugins I get the The plugin "Shibboleth Authentication Plugin" has been enabled. notification but the checkbox is not checked. The console reports the following:

Uncaught Error: Row with id googlescholarplugin not found!
    at a.pkp.controllers.grid.GridHandler.resequenceRows (pkp.min.js:273)
    at a.pkp.controllers.grid.GridHandler.replaceElementResponseHandler (pkp.min.js:281)
    at Object.success (pkp.min.js:124)
    at j (jquery.min.js:2)
    at Object.fireWith [as resolveWith] (jquery.min.js:2)
    at x (jquery.min.js:4)
    at XMLHttpRequest.b (jquery.min.js:4)

Note that the Settings Google Scholar Indexing Plugin happens to be the first plugin in the list of Generic Plugins.

On our test OJS 3.0.2 I installed the shibboleth plugin gia .tar.gz upload. I was able to enable it, configure it and use it successfully!

I'll be happy to provide more feedback and/or move this query to the forum.

asmecher · 2017-11-09T17:29:03Z

Hi @kasioumis,

Could you check if this will resolve the issue on your OJS 3.1.0 installation?

Execute the following SQL: DELETE FROM versions WHERE product='ShibbolethAuthPlugin';
Execute: rm -rf plugins/generic/ShibbolethAuthPlugin
Try installing the updated release from https://github.com/pkp/shibboleth/releases/tag/ojs-3_1_0-0-1 by uploading it into your OJS.

If you can confirm that this works, I'll update the version in the plugin gallery.

kasioumis · 2017-11-13T12:29:55Z

Hi @asmecher,

I confirm that the updated shibboleth release (ojs-3_1_0-0-1) can be installed and set up without any problems on OJS 3.1.0.

Thanks!

asmecher · 2017-11-15T23:48:24Z

Great, thanks! I've already put the updated version into the plugin galley.

asmecher reviewed Sep 26, 2017

View reviewed changes

crism added 25 commits October 12, 2017 12:17

pkp#1963: stub plugin

3e575f3

pkp#1963: fix syntax errors, add locale stub

a19f901

pkp#1963: add enable/disable code from LazyLoadPlugin.

96bedaa

pkp#1963: added the wayf URL setting... creeping slowly toward comple…

ff8e7b2

…tion...

pkp#1963: disable enabling if globally enabled

e5e6caa

pkp#1963: attempt at page-load hook callback...

a44945c

pkp#1963: Moving Shibboleth auth to a generic plugin.

89c919f

pkp#1963: moving Shibboleth files from auth to generic.

4451828

pkp#1963: finish transition from auth to generic category

c857d45

pkp#1963: marking it as a site-wide plugin

0d8083b

pkp#1963: adding UIN header, config requirement to Shibboleth plugin

0d9dde4

pkp#1963: fixing typo, looking for UIN header

e9dd298

pkp#1963: check for failures in Shibboleth auth

b5bc1b6

pkp#1963: adding heading and admin settings to Shibboleth plugin

e51c540

pkp#1963: cleaning up Shibboleth settings form

8375812

pkp#1963: working on actual login stuff

c3c0d68

pkp#1963: Fixing a few bugs...

2a6146f

pkp#1963: actual login from Shibboleth (I think)

299d86b

pkp#1963: Shibboleth login plus admin authorization

f2cc484

pkp#1963: fixing a few errors in Shibboleth plugin

db45153

pkp#1963: fixing logic flow for Shibboleth

9dfa8eb

pkp#1963: whitespace cleanup

6520ed1

pkp#1963: used wrong DAO to look for user in group...

06b1da9

pkp#1963: didn’t need UserGroupAssignmentDAO after all

cabd790

pkp#1963: adding new user registration from Shibboleth

c4fbc30

crism added 10 commits October 12, 2017 12:17

pkp#1963: important sense inversion in Shibboleth plugin...

5ecafba

pkp#1963: fixing UserDAO usage

5a58635

pkp#1963: cleanup before changing getSetting in Shibboleth plugin

4c4542f

pkp#1963: better settings management when globally enabled

f209153

pkp#1963: fixing form errors in Shibboleth plugin settings

7f362a4

pkp#1963: Hijack login and registration pages for Shibboleth.

3dd4592

pkp#1963: catch signOut, send to context home page

ca93b73

pkp#1963: better handling of logging out in context 0

45f8c5f

pkp#1963: final tweak, Shibboleth plugin version to 0.1

47858a5

pkp#1963: Fixing review comments.

3e86b08

crism force-pushed the issue-1963 branch from 948532b to 3e86b08 Compare October 12, 2017 16:26

pkp#1963: removing obsolete reference usage.

609dfb0

asmecher merged commit c587960 into pkp:master Oct 20, 2017

crism deleted the issue-1963 branch October 20, 2017 15:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue #1963: add Shibboleth authentication capability #2661

Issue #1963: add Shibboleth authentication capability #2661

crism commented Jul 19, 2017 •

edited

Loading

asmecher Sep 26, 2017

crism Sep 26, 2017

asmecher Sep 26, 2017

crism Sep 26, 2017

asmecher Sep 26, 2017

crism Sep 26, 2017

asmecher commented Sep 26, 2017

vieville commented Oct 4, 2017

crism commented Oct 12, 2017

crism commented Oct 12, 2017

asmecher commented Oct 20, 2017

asmecher commented Oct 20, 2017

kasioumis commented Oct 20, 2017

crism commented Oct 20, 2017

asmecher commented Oct 20, 2017

asmecher commented Oct 20, 2017

crism commented Oct 20, 2017

asmecher commented Oct 20, 2017

kasioumis commented Nov 5, 2017

asmecher commented Nov 7, 2017

kasioumis commented Nov 7, 2017 •

edited

Loading

asmecher commented Nov 9, 2017

kasioumis commented Nov 13, 2017

asmecher commented Nov 15, 2017

Issue #1963: add Shibboleth authentication capability #2661

Issue #1963: add Shibboleth authentication capability #2661

Conversation

crism commented Jul 19, 2017 • edited Loading

asmecher Sep 26, 2017

Choose a reason for hiding this comment

crism Sep 26, 2017

Choose a reason for hiding this comment

asmecher Sep 26, 2017

Choose a reason for hiding this comment

crism Sep 26, 2017

Choose a reason for hiding this comment

asmecher Sep 26, 2017

Choose a reason for hiding this comment

crism Sep 26, 2017

Choose a reason for hiding this comment

asmecher commented Sep 26, 2017

vieville commented Oct 4, 2017

crism commented Oct 12, 2017

crism commented Oct 12, 2017

asmecher commented Oct 20, 2017

asmecher commented Oct 20, 2017

kasioumis commented Oct 20, 2017

crism commented Oct 20, 2017

asmecher commented Oct 20, 2017

asmecher commented Oct 20, 2017

crism commented Oct 20, 2017

asmecher commented Oct 20, 2017

kasioumis commented Nov 5, 2017

asmecher commented Nov 7, 2017

kasioumis commented Nov 7, 2017 • edited Loading

asmecher commented Nov 9, 2017

kasioumis commented Nov 13, 2017

asmecher commented Nov 15, 2017

crism commented Jul 19, 2017 •

edited

Loading

kasioumis commented Nov 7, 2017 •

edited

Loading