pkp/pkp-lib#3157 fix required tagit metadata fields validation #3158
Conversation
| @@ -67,6 +67,10 @@ function addChecks($submission) { | |||
| if ($context->getSetting($key . 'Required')) switch(1) { | |||
| case in_array($key, $this->getLocaleFieldNames()): | |||
| $this->_parentForm->addCheck(new FormValidatorLocale($this->_parentForm, $key, 'required', 'common.required', $submission->getLocale())); | |||
| break; | |||
| case in_array($key, $this->getTagitFieldNames()): | |||
| $this->_parentForm->addCheck(new FormValidatorCustom($this->_parentForm, $key, 'required', 'common.required', create_function('$key,$form,$name', '$data = $form->getData(\'keywords\'); return array_key_exists($name, $data);'), array($this->_parentForm, $submission->getLocale().'-'.$key))); | |||
There was a problem hiding this comment.
What's happening when we call $form->getData(\'keywords\')? It seems to me like the form can only have one tag it field's data stored at keywords. So if I have metadata for disciplines and keywords, how does it know to check for each one? I may be missing something here, but just trying to figure out what's happening here.
There was a problem hiding this comment.
All tagit fields are called keywords, s. https://github.com/pkp/pkp-lib/blob/master/templates/form/keywordInput.tpl -- I do not why -- maybe there was a reason for that. Then they have an index <locale>-<key>. i.e. for the discipline and multilanguage the field would have the name keywords['en-US-disciplines'][] and for the keywords it would be keywords['en-US-keywords'][]. Thus the function gets all tagit fields with $form->getData(\'keywords\') and then it looks if the appropriate array key exists -- for example, for key = disciplines and submission locale = en-US , the function would look if that array key en-US-disciplines exists in $data. The appropriate array key is given as the last parameter $name = $submission->getLocale().'-'.$key to the function.
OK?
There was a problem hiding this comment.
Ah ok! That makes sense. No wonder I was confused. :)
|
Replaced by #3241 |
s. #3157