Bugfix/main/8929 migration issues

[jonasraoni]

No description provided.

[jonasraoni]

@asmecher, I'm not sure if the tests will pass, but I'm not going to do extra changes after the last commit, only fixes.

I'll try to explain briefly what I did.

1. First I executed a generic query to find missing FKs against OJS 3.4 and created all of them.
2. I didn't want to validate manually the existing cleanup code (too error prone), so using this model/ready database, I wrote a query to generate the PHP code to cleanup the foreign keys (if the field is NOT NULL > delete records, otherwise it depends), which resulted in extra cleanups.
3. Then I compared this code against the previous cleanup, mostly to collect exceptions:

• submission.current_publication_id is physically nullable, but conceptually required
• Special values, such as library_files.submission_id = 0
• ...

4. On top of that I've added other minor fixes (handle a missing issueId at the publication_settings, attempt to grab a missing submission.locale from the publications table, etc.)
5. Sorting the cleanup operations manually didn't give me confidence that things will work. So I wrote another query to collect the foreign key relationships, and used this to process the operations considering the "side-effects". It might re-run some cleanups, but it's better safe than sorry.

About the extra foreign keys, I've added another migration to handle them at the end, I searched fast and found at least one migration making use of the special value 0.

[jonasraoni]

@asmecher As the tests passed, I've created and assigned the remaining PRs to the issue:

[jonasraoni]

I just did a migration for Coalition Publica and it worked fine, after fixing the bug below (the field should be connected with the authors table instead of users), I'll include a fix for it as well:
https://github.com/pkp/ojs/blob/89363cae4a766851e2670db1a2cc18c2624bfdcb/classes/migration/upgrade/v3_4_0/I6093_AddForeignKeys.php#L91

I think it's worth to:

• Double check the foreign key setup on the migrations (only the ones responsible to create entities), to ensure everything is well wired
• Upgrade an installation from OJS 3.1 and compare their database structure, they should be identical.

[jonasraoni]

Superseded by #9071