Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings for journal managers #31
Settings for journal managers #31
Changes from 47 commits
0da44a2
3d949f2
907db25
a2a3295
3d08477
5fde58b
7298077
4749d71
2ef3fb0
8411f9a
b22dcfb
1cf6026
0273cc0
763f18f
7ad9c0d
d35ba37
14afbc1
fb1a165
d181a94
714cbf4
cd52598
5f08ce0
8720530
bb96dcb
8e6dec5
5e6d859
570e2c2
c09946b
6e14730
761d01f
7fc1ab3
813fa1c
1c1a9b7
9eca5b4
b07448e
43506e8
2509468
a7e8791
809b2ef
1072ef6
6862c9a
ff02441
7f748e5
ab2b940
79fdfd9
79c37b9
5f82f89
3f99871
4907b24
86f33da
e223660
84d7412
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I heard this raised already -- but I think a trivial notification probably isn't a good fit. It'll cause a toast notification that will go away, possibly before it can be read/digested, and there's no way to get it back. Maybe an email would be better as per e.g. the Paypal plugin? (The likeliest course of action will be that an editor will get an inscrutable error message and pass it on to an administrator of some kind, so maybe it should be going to the tech contact instead of all editors?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. We'd like to migrate these to Tasks instead of Trivial Notifications, but we didn't come up with an example of creating a Task in the Sprint. Error messages should be routed to Journal Managers or Administrators, depending on if the settings come from the form, or from config.inc.php. I could also imagine creating Tasks for Editors in the future as part of the review of the plagiarism check. I'd prefer to take care of this in an enhancement round after an initial merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Propose to handle in a new PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the
trim
call necessary? What if the password intentionally begins or ends with a"
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@radekgomola asserted that this was strangely needed. I have a vague memory of encountering and removing this formulation in other plugins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hej @radekgomola! Řekni mi co jsi našel.
This file was deleted.