Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing notifications/invalid call to Plugin::manage() #67

Closed
jonasraoni opened this issue Feb 21, 2023 · 0 comments · Fixed by #69, #70, #71 or #72
Closed

Missing notifications/invalid call to Plugin::manage() #67

jonasraoni opened this issue Feb 21, 2023 · 0 comments · Fixed by #69, #70, #71 or #72
Assignees
@jonasraoni
Labels
bug Something isn't working Bug:1:Low
Milestone
2.0.4-3

Comments

@jonasraoni
Copy link
Collaborator

jonasraoni commented Feb 21, 2023 •
edited

Even though this isn't going to be called, the call is using invalid variables/arguments.

pln/PLNPlugin.inc.php

Line 414 in 49f2b90

return parent::manage($verb, $args, $message, $messageParams);

I guess this was supposed to fire a notification, so as part of this task, the notification might be implemented properly.

At this moment, the plugin notifications are unhelpful/annoying, due to a bug where the text content is absent.

Source:
https://forum.pkp.sfu.ca/t/null-notifications-what-are-those-supposed-to-be/64832
@jonasraoni jonasraoni added bug Something isn't working Bug:1:Low labels Feb 21, 2023
@jonasraoni jonasraoni added this to the 2.0.4-3 milestone Feb 21, 2023
@jonasraoni jonasraoni self-assigned this Feb 21, 2023
jonasraoni added a commit to jonasraoni/pln that referenced this issue Feb 22, 2023
@jonasraoni
pkp#67 Fixed empty notifications
35bb530
jonasraoni added a commit to jonasraoni/pln that referenced this issue Feb 22, 2023
@jonasraoni
pkp#67 Formatting
2d3d9e5
jonasraoni added a commit to jonasraoni/pln that referenced this issue Feb 22, 2023
@jonasraoni
pkp#67 Formatting
b4466f9
jonasraoni added a commit to jonasraoni/pln that referenced this issue Feb 22, 2023
@jonasraoni
pkp#67 Fixed empty notifications
ea6a56d
jonasraoni added a commit that referenced this issue Feb 22, 2023
@jonasraoni
Merge pull request #69 from jonasraoni/bugfix/main/67-fix-empty-notif…
cb32ce9 
…ications

#67 Fixed empty notifications
This was linked to pull requests Feb 22, 2023
#67 Fixed empty notifications #69
Merged
Bugfix/stable 3 3 0/67 fix empty notifications #70
Merged
jonasraoni added a commit to jonasraoni/pln that referenced this issue Feb 22, 2023
@jonasraoni
pkp#67 Re-enabled "pln_accepting" check
17f5f49
jonasraoni added a commit to jonasraoni/pln that referenced this issue Feb 22, 2023
@jonasraoni
pkp#67 Dropped not needed code
44a0da0
jonasraoni added a commit to jonasraoni/pln that referenced this issue Feb 22, 2023
@jonasraoni
pkp#67 Dropped not needed locale keys
3e78b72
jonasraoni added a commit to jonasraoni/pln that referenced this issue Feb 22, 2023
@jonasraoni
pkp#67 Re-enabled "pln_accepting" check
70a54e3
jonasraoni added a commit to jonasraoni/pln that referenced this issue Feb 22, 2023
@jonasraoni
pkp#67 Dropped not needed code
cca3829
jonasraoni added a commit to jonasraoni/pln that referenced this issue Feb 22, 2023
@jonasraoni
pkp#67 Dropped not needed locale keys
1db1e99
jonasraoni added a commit to jonasraoni/pln that referenced this issue Feb 22, 2023
@jonasraoni
pkp#67 Re-enabled "pln_accepting" check
7de1c23
jonasraoni added a commit to jonasraoni/pln that referenced this issue Feb 22, 2023
@jonasraoni
pkp#67 Dropped not needed code
9c9e1b2
jonasraoni added a commit to jonasraoni/pln that referenced this issue Feb 22, 2023
@jonasraoni
pkp#67 Dropped not needed locale keys
cc2ea51
This was linked to pull requests Feb 22, 2023
Bugfix/stable 3 3 0/67 fix empty notifications #71
Merged
Bugfix/main/67 fix empty notifications #72
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonasraoni jonasraoni

Labels
bug Something isn't working Bug:1:Low
Projects
Plugins and Themes
Status: Done
Milestone
2.0.4-3
1 participant
@jonasraoni