Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing access within submission workflow stages #30

Closed
ctgraham opened this issue Oct 11, 2019 · 1 comment · Fixed by #31
Closed

Editing access within submission workflow stages #30

ctgraham opened this issue Oct 11, 2019 · 1 comment · Fixed by #31

Comments

@ctgraham
Copy link
Contributor

The "Edit with Texture" link formulates with a stageId:

$dispatcher->url($request, ROUTE_PAGE, null, 'texture', 'editor', null,
array(
'submissionId' => $submissionFile->getSubmissionId(),
'fileId' => $submissionFile->getFileId(),
'stageId' => $stageId
)
)

This is, presumably, the workflow stage, given that it generally sources from the fetch-grid call for a files grid, e.g. ojs/index.php/test/$$$call$$$/grid/files/production-ready/production-ready-files-grid/fetch-grid?submissionId=3&stageId=5&_=1570819236851

It fails to be assigned any value in a new submission as soon as the wizard moves beyond the initial upload.

Steps to reproduce:

  1. As author, start a new submission
  2. Upload a JATS XML and Dependent Files
  3. Finalize the Submission.
  4. Return to the Submission (ojs/index.php/test/$$$call$$$/grid/files/submission/author-submission-details-files-grid/fetch-grid?submissionId=1&_=1570820690723)
  5. Try to Edit With Texture (fails)

or

  1. Do not finalize the Submission
  2. Return to the Submission (ojs/index.php/test/$$$call$$$/grid/files/submission/submission-wizard-files-grid/fetch-grid?submissionId=4&_=1570820830259)
  3. Try to Edit With Texture (fails)

There is no need to rely on the URI for the workflow stage. We can get it from the submission.

ctgraham added a commit to ulsdevteam/texture that referenced this issue Oct 11, 2019
withanage added a commit that referenced this issue Oct 11, 2019
#30: pull workflow stage from submission
@withanage
Copy link
Member

Thanks @ctgraham for the PR. Merged it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants