Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkp/pkp-lib#9527 Mark for review #328

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

jardakotesovec
Copy link
Collaborator

No description provided.

Copy link
Contributor

@jonasraoni jonasraoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I've checked this yesterday and I think everything makes sense, it's not covering all changes (regarding Vue 3), and I think it shouldn't, as the official documentation is really the best guide. I just see grammar typos, but it's better for a native to get them fixed :)

@jardakotesovec
Copy link
Collaborator Author

@jonasraoni Great, thanks for checking!

@jardakotesovec jardakotesovec merged commit 8dc0d9e into pkp:main Feb 19, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants