Handling of wxMemoryBuffer is improved to avoid unnecessary dependence #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ildar, does this patch fix the compilation issue? |
|
@toshinagata, thank you for the changes. They look good to me; I'll just wait for @ildar to confirm it fixed the compilation issue. |
|
Guys, I confirm this PR fixed the underlinking issue. And I don't see
anything broken with it.
Thanks.
|
|
Thank you for checking and to @toshinagata for providing the patch! Merged the changes... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this helps to solve Issue #63 .