Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect System.out calls to plugin loggers #429

Merged
merged 3 commits into from Jul 1, 2021
Merged

Conversation

BillyGalbreath
Copy link
Contributor

Opening this as a PR in case anyone has ideas for improvement.

We've been wanting to add this for a long time now, and this is basically a direct copy of Vicarious' plugin logic that works for Java 8+. I heard there was an easier/better way with the newer Java versions.

@BillyGalbreath BillyGalbreath force-pushed the SysoutCatcher branch 2 times, most recently from 85a553f to 88d23e0 Compare June 28, 2021 21:25
Copy link
Member

@YouHaveTrouble YouHaveTrouble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see any way to improve it further tbh, lgtm and seems to be correct

@BillyGalbreath BillyGalbreath merged commit b08901f into ver/1.17 Jul 1, 2021
@BillyGalbreath BillyGalbreath deleted the SysoutCatcher branch July 1, 2021 01:34
Euphillya added a commit to ExcaliaSI/Purpur-SinonMC that referenced this pull request Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants